summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* libxsettings-client: fix SRC_URIPaul Eggleton2011-12-211-1/+1
| | | | | | | projects.o-hand.com downloads have moved to downloads.yoctoproject.org Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* libmatchbox: fix SRC_URIPaul Eggleton2011-12-211-1/+1
| | | | | | | projects.o-hand.com downloads have moved to downloads.yoctoproject.org Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* matchbox-themes-extra: fix SRC_URIPaul Eggleton2011-12-211-1/+4
| | | | | | | | * projects.o-hand.com downloads have moved to downloads.yoctoproject.org * Add missing SRC_URI checksums Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* matchbox-desktop: fix SRC_URIPaul Eggleton2011-12-212-2/+8
| | | | | | | | * projects.o-hand.com downloads have moved to downloads.yoctoproject.org * Add missing SRC_URI checksums Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* xrestop: fix SRC_URI and LICENSEPaul Eggleton2011-12-211-3/+3
| | | | | | | | | | | * projects.o-hand.com downloads have moved to downloads.yoctoproject.org * LICENSE syntax was invalid (should use & instead of + to signify mixed license). I have set it to GPLv2+ since there is only one source file and that's the license it states. (Note - even if it was a mix of GPLv2+ and GPLv2 code the result would be GPLv2 only.) Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* less: Correcting generic licenseBeth Flanagan2011-12-211-3/+3
| | | | | | | | | I've asked and received permission from Mark Nudelman, the author of less, to utilize a generic BSD 2 clause license for less, instead of creating a common "less" license file. Signed-off-by: Beth Flanagan <elizabeth.flanagan@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* task-core-tools: add ltp to testapps listJiajun Xu2011-12-211-1/+2
| | | | | Signed-off-by: Jiajun Xu <jiajun.xu@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* distro_tracking_fields: add information for ltpJiajun Xu2011-12-211-0/+8
| | | | | | | Add information for recipe ltp, which is ported from OE. Signed-off-by: Jiajun Xu <jiajun.xu@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ltp: Add recipe from OEJiajun Xu2011-12-211-0/+68
| | | | | | | | | | | | Port ltp recipe from OE and upgraged to latest version(20110915). Install ltp into ${D}/opt/ltp and POSIX test suite is also copied into ${D}/opt/ltp/testcases. TODO: Some cases are removed since they depend on command 'expect'. It is not in Poky or OE and we will add it for enhancement next. Signed-off-by: Jiajun Xu <jiajun.xu@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* license: Fix manifest conditionalBeth Flanagan2011-12-211-2/+2
| | | | | | | | | The manifest conditionals COPY_LIC_MANIFEST and COPY_LIC_DIRS were returning true due to missing quotes in the bash test. This made images larger than expected. Signed-off-by: Beth Flanagan <elizabeth.flanagan@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ncurses: Allow override of ENABLE_WIDECDarren Hart2011-12-211-1/+1
| | | | | | | | Set ENABLE_WIDEC with ?= instead of = to allow for the external override by distro definitions. Signed-off-by: Darren Hart <dvhart@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* matchbox-session-sato: clarify LICENSE in GPLv2.0Joshua Lock2011-12-211-1/+1
| | | | Signed-off-by: Joshua Lock <josh@linux.intel.com>
* matchbox-desktop: clarify LICENSE is GPLv2.0+Joshua Lock2011-12-212-2/+2
| | | | Signed-off-by: Joshua Lock <josh@linux.intel.com>
* pango: clarify LICENSE is LGPLv2.0+Joshua Lock2011-12-211-1/+1
| | | | Signed-off-by: Joshua Lock <josh@linux.intel.com>
* matchbox-wm: clarify LICENSE as GPLv2.0Joshua Lock2011-12-211-1/+1
| | | | Signed-off-by: Joshua Lock <josh@linux.intel.com>
* cogl: clarify LICENSE as LGPLv2.1 and fix metadataJoshua Lock2011-12-211-3/+3
| | | | | | Fix the HOMEPAGE and DESCRIPTION which were using the same values as Clutter. Signed-off-by: Joshua Lock <josh@linux.intel.com>
* clutter: clarify LICENSE as LGPLv2.1Joshua Lock2011-12-211-1/+1
| | | | Signed-off-by: Joshua Lock <josh@linux.intel.com>
* dpkg: clarify LICENSE as GPLv2.0Joshua Lock2011-12-211-1/+1
| | | | Signed-off-by: Joshua Lock <josh@linux.intel.com>
* apt: clarify LICENSE as GPLv2.0Joshua Lock2011-12-211-1/+1
| | | | Signed-off-by: Joshua Lock <josh@linux.intel.com>
* udev: tidy the LICENSE fieldsJoshua Lock2011-12-212-4/+4
| | | | | | Signed-off-by: Joshua Lock <josh@linux.intel.com> fix udev
* gypsy: fix LICENSE fieldJoshua Lock2011-12-211-1/+1
| | | | | | Gypsy binaries are Gplv2.0 and the libraries LGPLv2.1 Signed-off-by: Joshua Lock <josh@linux.intel.com>
* libsdl 1.2.14: fix packagingKoen Kooi2011-12-191-2/+2
| | | | | | | | | | | | | | | For some reason the -config script was shipped in ${PN} leading to shlibs renaming issues: What we want, and how meta-oe used to do it: libsdl-1.2-0_1.2.14-r0.0_armv7a.ipk Current OE-core status: libsdl_1.2.14-r2_armv7a.ipk With this commit we get both proper shlib renaming and the -dev package now has all the dev files Signed-off-by: Koen Kooi <koen@dominion.thruhere.net> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* eglibc: Fixes for running regression testsKhem Raj2011-12-197-171/+77
| | | | | | | | | | | | | | | | | | | | | Override cxx-sysincludes along with CC and CXX since it contains path pointing to tcbootstrap sysroot which does not have c++ headers and libraries Drop shorten-build-commands patch since it did not override the include flags for c++ headers when tests written in c++ are executed the @includes file does not get updated to add c++ header paths This patch only reduced the build output anyway Add a patch to point eglibc to look into c++ headers the way OE installs them its not standard install e.g. usr/include/c++/GCC_VER but instead usr/include/c++. This lets g++ find the headers in right place when compiling c++ testcases Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* gcc-4.6: Let G++ relocate gxx-include-dir when using --sysroot optionKhem Raj2011-12-194-23/+174
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently we have a problem in our cross compiler since we use /usr/include/c++ to be default gxx-include-dir and then expect the patch we did to do the relocation w.r.t. sysroot however it does not quite work so and we end up gxx-include-dirs not respecting sysroot. A small test case would be tst-unique4.cc and it would fails like tst-unique4.cc:1:18: fatal error: cstdio: No such file or directory compilation terminated. weather we use --sysroot or not it does not matter arm-oe-linux-gnueabi-g++ -S tst-unique4.cc --sysroot=/home/kraj/work/angstrom/sources/openembedded-core/build/tmp-eglibc/sysroots/qemuarm failed in same way. so we redo the GPLUSPLUS_INCLUDE_DIR_with_sysroot.patch based on upstream submitted patch which tries to relocate the gxx-include-dir and to achieve the relocation it has to be specified w.r.t to --with-sysroot directory. e.g. --with-sysroot=${SYSROOT} --with-gxx-include-dir=${SYSROOT}/usr/include/c++ if we configure gcc like above then it becomes relocatable when we run the compiler and specify --sysroot=<blah> then g++ will search for gxx-headers under <blah>/usr/include/c++ if sysroot is not defined then it will use the default sysroot and gxx-include-dir will be w.r.t. default sysroot. Tested on qemuarm /arm-oe-linux-gnueabi-g++ -S tst-unique4.cc --sysroot=/home/kraj/work/angstrom/sources/openembedded-core/build/tmp-eglibc/sysroots/qemuarm -v ... /home/kraj/work/angstrom/sources/openembedded-core/build/tmp-eglibc/sysroots/qemuarm/usr/include/c++ /home/kraj/work/angstrom/sources/openembedded-core/build/tmp-eglibc/sysroots/qemuarm/usr/include/c++/arm-oe-linux-gnueabi /home/kraj/work/angstrom/sources/openembedded-core/build/tmp-eglibc/sysroots/qemuarm/usr/include/c++/backward ... and if I now change --sysroot to something else /arm-oe-linux-gnueabi-g++ -S tst-unique4.cc --sysroot=/home/kraj/work/angstrom/sources/openembedded-core/build/tmp-eglibc/sysroots/qemuarm4 -v ... ignoring nonexistent directory "/home/kraj/work/angstrom/sources/openembedded-core/build/tmp-eglibc/sysroots/qemuarm4/usr/include/c++" ignoring nonexistent directory "/home/kraj/work/angstrom/sources/openembedded-core/build/tmp-eglibc/sysroots/qemuarm4/usr/include/c++/arm-oe-linux-gnueabi" ignoring nonexistent directory "/home/kraj/work/angstrom/sources/openembedded-core/build/tmp-eglibc/sysroots/qemuarm4/usr/include/c++/backward" ... See now its looking for them in 'qemuarm4' sysroot Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* [PATCH 2/4] gcc-cross: Add cross testing driver for running regression ↵Khem Raj2011-12-191-1/+90
| | | | | | | | | | | | | | | | | | | testsuites This script will be generated into the build directory of gcc-cross It should be testing gcc and g++. libstdc++ tests are not run since we build them as part of gcc-runtime but we can test them here by building them with 'make all' and then running the tests The script expects passwordless ssh access to target and is used in form ./arm-oe-linux-gnueabi-testgcc kraj@192.168.7.2 inside the builddir of gcc-cross Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* eglibc-testing: Clean the test before running themKhem Raj2011-12-191-1/+35
| | | | | | | | | | | | | | | | We make sure that we use final cross gcc to run the tests since they require proper functioning libstdc++ and libssp which are not staged in tcbootstrap sysroot We cleanup the tests before we run them so they all get run in case any of them were built and/or run during compilation Make the script executable Add more documentation to diagnose setup problems Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* connman: disable 'alg-test' buildingOtavio Salvador2011-12-193-9/+48
| | | | | | | | 'alg-test' requires 'linux/if_alg.h' header enforcing a dependency on linux-libc-headers 2.6.39 or newer. Signed-off-by: Otavio Salvador <otavio@ossystems.com.br> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* icecc.bbclass: also use icecc for kernel modules compilationDmitry Eremin-Solenikov2011-12-191-0/+4
| | | | | Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* libatomics-ops: move docs to correct directoryDmitry Eremin-Solenikov2011-12-191-2/+4
| | | | | Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Add missing SUMMARY fields to various recipesScott Garman2011-12-196-4/+9
| | | | | | | | | | | | | | | This adds the SUMMARY field to the following recipes which were missing it: * dosfstools * grep * icu * libevent * libnfsidmap * qemu-helper-nativesdk Signed-off-by: Scott Garman <scott.a.garman@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* mktemp: mark patch as upstreamedScott Garman2011-12-191-1/+2
| | | | | | | Patch sumitted and accepted upstream, updating Upstream-Status. Signed-off-by: Scott Garman <scott.a.garman@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* opkg: Drop the offlineroot_varname patchRichard Purdie2011-12-192-22/+1
| | | | | | | This break things for on target opkg usage since $D must remain unset there. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* opkg: Add logic to detect and creak circular dependenciesRichard Purdie2011-12-192-1/+101
| | | | | | | | This addresses some of the concerns about the previous opkg changes allowing it to break out of circular dependency loops with just a notice in the logs rather than effectively going OOM. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* license.bbclass: remove bashismElizabeth Flanagan2011-12-161-1/+1
| | | | | | | Removing a bashism that was dumping errors into rootfs log. Signed-off-by: Elizabeth Flanagan <elizabeth.flanagan@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* readline: drop empty dir to shut up QA warningDmitry Eremin-Solenikov2011-12-161-0/+2
| | | | | Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* libgcc: reintroduce debug package, containing symbolsDmitry Eremin-Solenikov2011-12-161-0/+3
| | | | | Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* bitbake.conf, core-image-minimal-initramfs: add INITRAMFS_FSTYPESDmitry Eremin-Solenikov2011-12-162-1/+2
| | | | | | | | | | | | | | Initramfs images don't benefit from usual IMAGE_FSTYPES overrides. The only sane values for them are "cpio.XXX". If IMAGE_FSTYPES is set to include 'live', building core-image-minimal-initramfs can result in build error, if the image is built before the kernel. To stop initramfs images from responding on IMAGE_FSTYPES settings, but still allow users/developers to override defaults (e.g. to generate "cpio.lzma" initramfs), introduce INITRAMFS_FSTYPES variable, by default set to "cpio.gz". Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* update-rc.d.bbclass: override UPDATERCD for nativesdkBernhard Guillon2011-12-161-0/+2
| | | | | | | | | | Override UPDATERCD for nativesdk. Without, update-rc.d is installed to /usr/sbin/update-rc.d with meta-toolchain if nativesdk recipe inherits update-rc.d. An example recipe for this is dbus. Signed-off-by: Bernhard Guillon <Bernhard.Guillon@hale.at> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* ed: Fix EXTRA_OECONF to ensure right compiler is foundSaul Wold2011-12-161-1/+4
| | | | | Signed-off-by: Saul Wold <sgw@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* libical: Fix deadlock in pthreadZhai Edwin2011-12-162-1/+56
| | | | | | | | | | | | libical introduce pthread support after 0.47, but lead deadlock with missing some unlock code. This makes dates start hang. Add new patch to properly release mutex. [YOCTO #1825] got fixed. Signed-off-by: Zhai Edwin <edwin.zhai@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* xserver-nodm-init: Fix xuser creationZhai Edwin2011-12-161-3/+3
| | | | | | | Rootless X start fail as xuser has no home and shell. This patch fix it. Signed-off-by: Zhai Edwin <edwin.zhai@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* opkg: Update svn 625 -> 633 and fix preinst issuesRichard Purdie2011-12-166-26/+260
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There is a major issue with opkg images at the moment as preinst functions are not being executed before their dependencies are installed and this is leading to corruption of images containing avahi/dbus in particular. There are various changes in upstream opkg in the last 8 revisions which make changes in this area but sadly these aren't enough to get things working for us. I've updated to the latest svn revision with this patch since it makes sense to pull in those changes first and then supplement them with the attached patches. There is a full description of the patches in the patch headers but in summary they: a) Ensure preinst functions execute with their dependencies installed. This is a pretty invasive change as it changes the package install ordering in general. b) Ensure opkg sets $D, not $PKG_ROOT which we don't use c) Change opkg to allow execution of postinstall functions which fail resulting in execution on the target device as rootfs_ipk.bbclass currently does manually. The remaining changes interface this with the rest of the OE build infrastructure, adding in the option to tell opkg to run the preinst and postinst functions, ensure the correct environment is present for the postinst scripts and removing the now unneeded rootfs_ipk class code which opkg now does itself. [YOCTO #1711] Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* nativesdk.bbclass: Remove historical FILES artifactRichard Purdie2011-12-161-5/+0
| | | | | | | | | | | | | | Adding everything in ${prefix} to FILES and FILES-dbg is a historical artifact left over from when this was sdk.bbclass back in 2009. The BBCLASSEXTEND changes, multilib changes and cleanups to this file over the intervening time mean this is simply no long needed. Its also outright dangerous since it can link the packages together in circular ways which don't make sense. The simplest thing to is to drop this since it no longer does anything useful. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* bootimg: Use mcopy to construct the hddimgDarren Hart2011-12-161-5/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | The initial directory support (-d) added to mkdosfs has proven to be incomplete and non-compliant with FAT. Rather than continue to maintain this feature and work around the various issues, we can use mcopy to construct the image. bootimg.bbclass already depends on mtools-native (although it may not have needed to previously). No new dependencies are introduced. The image created passes dosfsck cleanly. Remove the call to dosfsck. mcopy reported an error with the image we were creating: Total number of sectors (107574) not a multiple of sectors per track (32)! Add some logic to ensure the total sector count is an integral number of sectors per track, including forcing the logical sector size to 512 in the mkdosfs command. The du -bks arguments are contradictory, -b is equivalent to "--apparent-size --block-size=1" and -k is --block-size=1K. If reordered, -kbs will report the disk usage in bytes insteadk of 1k blocks. Eliminate the ambiguity by using: du --apparent-size -ks Signed-off-by: Darren Hart <dvhart@linux.intel.com> CC: Nitin A. Kamble <nitin.a.kamble@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* bootimg: Use dosfsck to clean up the generated live imageDarren Hart2011-12-161-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The generated filesystem has some errors that dosfsck is able to repair: dosfsck 2.11, 12 Mar 2005, FAT32, LFN Checking file /ldlinux.sys (LDLINUX.SYS) Checking file /initrd (INITRD) Checking file /syslinux.cfg (SYSLINUX.CFG) Checking file /EFI (EFI) Checking file /vmlinuz (VMLINUZ) Checking file /rootfs.img (ROOTFS.IMG) /vmlinuz File size is 4144896 bytes, cluster chain length is > 4145152 bytes. Truncating file to 4144896 bytes. Checking file /EFI/.. (..) Checking file /EFI/BOOT (BOOT) Checking file /EFI/. (.) /EFI/.. Start (16022) does not point to .. (0) /EFI/. Start (0) does not point to parent (16022) Checking file /EFI/BOOT/.. (..) Checking file /EFI/BOOT/. (.) Checking file /EFI/BOOT/initrd (INITRD) Checking file /EFI/BOOT/grub.cfg (GRUB.CFG) Checking file /EFI/BOOT/bootia32.efi (BOOTIA32.EFI) Checking file /EFI/BOOT/vmlinuz (VMLINUZ) Checking file /EFI/BOOT/rootfs.img (ROOTFS.IMG) /EFI/BOOT/.. Start (16021) does not point to .. (16022) /EFI/BOOT/. Start (0) does not point to parent (16021) /EFI/BOOT/vmlinuz File size is 4144896 bytes, cluster chain length is > 4145152 bytes. Truncating file to 4144896 bytes. Performing changes. /build/poky/fri2/tmp/deploy/images/core-image-minimal-fri2-noemgd-20111216000605.hddimg: 12 files, 26635/26828 clusters Add a dosfsck command following the mkdosfs command to correct these. Signed-off-by: Darren Hart <dvhart@linux.intel.com> CC: Nitin A Kamble <nitin.a.kamble@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* grub-efi: specify prefix so it can find grub.cfgDarren Hart2011-12-161-2/+2
| | | | | | | | | | | | Specify /EFI/BOOT as the grub prefix so the grub efi payload can find the grub.cfg in the same directory. Ultimately, it might make more sense to install the grub tools and the grub-core modules to sysroot and make the grub-efi bbclass generate the image in the required format as part of the bootimg generation. However, bootimg is currently the only user, so make the correction here to resolve the immediate issue. Signed-off-by: Darren Hart <dvhart@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* grub-efi: Add efi_gop module to payload for physical console supportDarren Hart2011-12-161-1/+1
| | | | | | | | | | Without the efi_gop module, the GRUB menu would work, but the Linux kernel messages would not be displayed to the physical console. Adding efi_gop causes grub to pass the proper information in the boot parameters pointer such that the Linux kernel can detect and use the EFI framebuffer. Signed-off-by: Darren Hart <dvhart@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* grub-efi: Use /EFI/BOOT now that mkdosfs -d works with directoriesDarren Hart2011-12-161-15/+3
| | | | | | | | | | [Yocto 1783] prevented us from using a proper /EFI/BOOT path in the live images due to a bug in the -d patch for mkdosfs in dosfstools. With this now fixed, we can place the efi payload where it belongs per spec and the images will autoboot to the grub menu on EFI platforms. Signed-off-by: Darren Hart <dvhart@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* Patch Upstream Status UpdatesSaul Wold2011-12-1526-0/+53
| | | | Signed-off-by: Saul Wold <sgw@linux.intel.com>
* perl: add .pl, pm, pod, sh files to SSTATE_SCANE_FILESSaul Wold2011-12-151-1/+4
| | | | | | | This fixes problems where hardcoded paths in the file were incorrect during sstate reusage of the task output. Signed-off-by: Saul Wold <sgw@linux.intel.com>