From 6ee0c26e21f48dcd47af88ed5c174e76e76a3e42 Mon Sep 17 00:00:00 2001 From: Yu Ke Date: Wed, 29 Dec 2010 15:28:48 +0800 Subject: bb.utils: check if lock file is writable, to fix bug 606 Bug 606 report that if $DL_DIR is read-only, do_fetch will simply hang without any error message. The root cause is that: bb.fetch.go()->bb.utils.lockfile() will try to lock file ${DL_DIR}/xxxxx.lock. Since ${DL_DIR} is read-only, it will cause IOError exception. Although lockfile() can catch the exception, currently code simply ignore all the exception and continue the loop. it make sense if the exception is caused by locking contention, but in the read-only $DL_DIR case, it cause endless waiting unfortunately. So this patch add read-only check for lockfile to avoid the silent hang. Fix [BUGID #606] Signed-off-by: Yu Ke --- bitbake/lib/bb/utils.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/bitbake/lib/bb/utils.py b/bitbake/lib/bb/utils.py index f468fafc1..e02969c07 100644 --- a/bitbake/lib/bb/utils.py +++ b/bitbake/lib/bb/utils.py @@ -401,6 +401,10 @@ def lockfile(name): bb.msg.error(bb.msg.domain.Util, "Error, lockfile path does not exist!: %s" % path) sys.exit(1) + if not os.access(path, os.W_OK): + bb.msg.error(bb.msg.domain.Util, "Error, lockfile path is not writable!: %s" % path) + sys.exit(1) + while True: # If we leave the lockfiles lying around there is no problem # but we should clean up after ourselves. This gives potential -- cgit v1.2.3