From 95185de6f149a495201701d260921339e3dfaebd Mon Sep 17 00:00:00 2001 From: Darren Hart Date: Fri, 13 May 2011 15:42:37 -0700 Subject: send-pull-request: verify git sendemail config Perform a quick sanity check to be able to direct users to configure git.sendemail if they haven't yet. Signed-off-by: Darren Hart Acked-by: Otavio Salvador Cc: Otavio Salvador --- scripts/send-pull-request | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/scripts/send-pull-request b/scripts/send-pull-request index 5a11d1f1e..21eb30216 100755 --- a/scripts/send-pull-request +++ b/scripts/send-pull-request @@ -41,6 +41,18 @@ harvest_recipients() unset IFS } +check_git_sendemail_config() +{ + GIT_SMTP=$(git config sendemail.smtpserver) + GIT_FROM=$(git config sendemail.from) + if [ -z "$GIT_SMTP" ] || [ -z "$GIT_FROM" ]; then + echo "ERROR: git sendemail is not configured." + echo "Please read GIT-SEND-EMAIL(1) and configure:" + echo " sendemail.smtpserver" + echo " sendemail.from" + exit 1 + fi +} # Parse and verify arguments while getopts "achp:t:" OPT; do @@ -74,6 +86,9 @@ while getopts "achp:t:" OPT; do esac done +# Abort early if git-send-email is not properly configured +check_git_sendemail_config + if [ -z "$PDIR" ]; then echo "ERROR: you must specify a pull-dir." usage -- cgit v1.2.3