From 9207cd40153148f71788d30697a055fe846e8927 Mon Sep 17 00:00:00 2001 From: Kevin Tian Date: Tue, 29 Jun 2010 08:54:03 +0800 Subject: qemu: fix VMware VGA depth calculation error VMware SVGA presents to the guest with the depth of the host surface it renders to, and rejects to work if the two sides are mismatched. One problem is that current VMware VGA may calculate a wrong host depth, and then memcpy from virtual framebuffer to host surface may trigger segmentation fault. For example, when launching Qemu in a VNC connection, VMware SVGA thinks depth as '32', however the actual depth of VNC is '16'. The fault also happens when the host depth is not 32 bit. Qemu <4b5db3749c5fdba93e1ac0e8748c9a9a1064319f> tempts to fix a similar issue, by changing from hard-coded 24bit depth to instead query the surface allocator (e.g. sdl). However it doesn't really work, because the point where query is invoked is earlier than the point where sdl is initialized. At query time, qemu uses a default surface allocator which, again, provides another hard-coded depth value - 32bit. So it happens to make VMware SVGA working on some hosts, but still fails in others. To solve this issue, this commit introduces a postcall interface to display surface, which is walked after surface allocators are actually initialized. At that point it's then safe to query host depth and present to the guest. Signed-off-by Kevin Tian --- meta/packages/qemu/qemu_git.bb | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'meta/packages/qemu/qemu_git.bb') diff --git a/meta/packages/qemu/qemu_git.bb b/meta/packages/qemu/qemu_git.bb index b1468704a..00b361063 100644 --- a/meta/packages/qemu/qemu_git.bb +++ b/meta/packages/qemu/qemu_git.bb @@ -1,7 +1,7 @@ require qemu.inc PV = "0.12.4" -PR = "r8" +PR = "r9" FILESPATH = "${FILE_DIRNAME}/qemu-${PV}/:${FILE_DIRNAME}/qemu-git/" FILESDIR = "${WORKDIR}" @@ -14,7 +14,8 @@ SRC_URI = "\ file://fix-dirent.patch \ file://fix-nogl.patch \ file://qemugl-allow-glxcontext-release.patch \ - file://linker-flags.patch" + file://linker-flags.patch \ + file://qemu-vmware-vga-depth.patch" S = "${WORKDIR}/git" -- cgit v1.2.3