From 25d82b0c52120c81cfed5bc1f245408f08203b7b Mon Sep 17 00:00:00 2001
From: Trygve Laugstøl <trygvis@inamo.no>
Date: Thu, 30 Aug 2018 22:17:06 +0200
Subject: Fixing lots of small nits: o boost::uuid didn't give much, use our
 own and add new short uuid type. o Fixing nits from clang-tidy.

---
 ble/Bluetooth.cpp      | 52 ++++++++++++++-----------------
 ble/BluetoothImpl.h    | 77 ++++++++++++++++++++++------------------------
 ble/LinuxBluetooth.cpp | 83 +++++++++++++++++++-------------------------------
 3 files changed, 90 insertions(+), 122 deletions(-)

(limited to 'ble')

diff --git a/ble/Bluetooth.cpp b/ble/Bluetooth.cpp
index 13c81b3..4160acc 100644
--- a/ble/Bluetooth.cpp
+++ b/ble/Bluetooth.cpp
@@ -71,14 +71,14 @@ AttPduType AttPdu::getType() {
     return (AttPduType) bytes.get8(0);
 }
 
-void AttPdu::makeReadByGroupType(ByteBuffer &bytes, uint16_t startHandle, uint16_t endHandle, SpecUuid uuid) {
+void AttPdu::makeReadByGroupType(ByteBuffer &bytes, uint16_t startHandle, uint16_t endHandle, ShortUuid uuid) {
     bytes.write8(AttPduType::READ_BY_GROUP_TYPE_REQ);
     bytes.write16le(startHandle);
     bytes.write16le(endHandle);
     bytes.write16le(uuid.value);
 }
 
-void AttPdu::makeReadByType(ByteBuffer &bytes, uint16_t startHandle, uint16_t endHandle, SpecUuid uuid) {
+void AttPdu::makeReadByType(ByteBuffer &bytes, uint16_t startHandle, uint16_t endHandle, ShortUuid uuid) {
     bytes.write8(AttPduType::READ_BY_TYPE_REQ);
     bytes.write16le(startHandle);
     bytes.write16le(endHandle);
@@ -99,14 +99,14 @@ void AttPdu::makeWrite(ByteBuffer &req, uint16_t handle, const ByteBuffer &bytes
 vector<AttributeData> AttPdu::parse(ByteBuffer &bytes, AttPduType type) {
     // cout << "bytes: " << bytes.toString();
 
-    AttPduType t = (AttPduType) bytes.read8();
+    auto t = static_cast<AttPduType>(bytes.read8());
 
-    if (t == INVALID_HANDLE) {
+    if (t == ERROR) {
         return vector<AttributeData>();
     }
 
     if (t != type) {
-        throw BluetoothException("Unexpected type: " + to_string(t));
+        throw BluetoothException("Unexpected type: " + to_string(t) + ", expected " + to_string(type));
     }
 
     if (bytes.getSize() < 4) {
@@ -138,11 +138,13 @@ vector<AttributeData> AttPdu::parseReadByType(ByteBuffer &bytes) {
     return parse(bytes, READ_BY_TYPE_RES);
 }
 
+static uint16_t parseExchangeMtuReq(ByteBuffer &bytes);
+
 void AttPdu::parseRead(ByteBuffer &bytes) {
     AttPduType t = (AttPduType) bytes.read8();
 
     if (t != READ_RES) {
-        throw BluetoothException("Unexpected type: " + to_string(t));
+        throw BluetoothException("Unexpected type: " + to_string(t) + ", expected " + to_string(READ_RES));
     }
 }
 
@@ -150,7 +152,7 @@ void AttPdu::parseWrite(ByteBuffer &bytes) {
     AttPduType t = (AttPduType) bytes.read8();
 
     if (t != WRITE_RES) {
-        throw BluetoothException("Unexpected type: " + to_string(t));
+        throw BluetoothException("Unexpected type: " + to_string(t) + ", expected " + to_string(WRITE_RES));
     }
 }
 
@@ -168,45 +170,36 @@ AttributeData::AttributeData(uint16_t handle, ByteBuffer value) :
         handle(handle), value(value) {
 }
 
-AttributeData::~AttributeData() {
-}
+AttributeData::~AttributeData() = default;
 
 // -----------------------------------------------------------------------
 // Gatt
 // -----------------------------------------------------------------------
 
-BluetoothGatt::BluetoothGatt() {
-}
+BluetoothGatt::BluetoothGatt() = default;
 
-BluetoothGatt::~BluetoothGatt() {
-}
+BluetoothGatt::~BluetoothGatt() = default;
 
 // -----------------------------------------------------------------------
 // Device
 // -----------------------------------------------------------------------
 
-BluetoothDevice::BluetoothDevice() {
-}
+BluetoothDevice::BluetoothDevice() = default;
 
-BluetoothDevice::~BluetoothDevice() {
-}
+BluetoothDevice::~BluetoothDevice() = default;
 
 // -----------------------------------------------------------------------
 // Adapter
 // -----------------------------------------------------------------------
 
-BluetoothAdapter::BluetoothAdapter() {
-}
-
-BluetoothAdapter::~BluetoothAdapter() {
-}
+BluetoothAdapter::BluetoothAdapter() = default;
 
+BluetoothAdapter::~BluetoothAdapter() = default;
 // -----------------------------------------------------------------------
 // Bluetooth System. This is not sub-classed by implementations.
 // -----------------------------------------------------------------------
 
-BluetoothSystem::BluetoothSystem() {
-}
+BluetoothSystem::BluetoothSystem() = default;
 
 BluetoothSystem::~BluetoothSystem() {
     adapters.clear();
@@ -223,11 +216,12 @@ shared_ptr<BluetoothAdapter> BluetoothSystem::getAdapter(string name) {
     return it->second;
 }
 
-uuid_t makeUuid(const uuid_t base, uint8_t a, uint8_t b) {
-    uuid_t c = base;
-    c.data[2] = a;
-    c.data[3] = b;
-    return c;
+Uuid makeUuid(const Uuid &base, uint8_t a, uint8_t b) {
+    uint8_t value[16];
+    memcpy(value, base.value, 16);
+    value[2] = a;
+    value[3] = b;
+    return Uuid{value};
 }
 
 }
diff --git a/ble/BluetoothImpl.h b/ble/BluetoothImpl.h
index 8663b20..c660b4b 100644
--- a/ble/BluetoothImpl.h
+++ b/ble/BluetoothImpl.h
@@ -25,14 +25,13 @@ namespace trygvis {
 namespace bluetooth {
 
 // Utility typedefs
-typedef boost::uuids::uuid uuid_t;
 using namespace log4cplus;
 
 // Logging
 
 class LogSetup {
 public:
-    LogSetup(std::string name) : logger(Logger::getInstance(LOG4CPLUS_TEXT(name))) {
+    explicit LogSetup(const std::string &name) : logger(Logger::getInstance(LOG4CPLUS_TEXT(name))) {
     }
 
 protected:
@@ -61,7 +60,7 @@ struct constify2<T *, U const *> {
 template<typename A, typename B>
 class CollectionImpl : public Collection<A> {
 public:
-    CollectionImpl(B &b) : b(b) {
+    explicit CollectionImpl(B &b) : b(b) {
     }
 
 private:
@@ -70,47 +69,46 @@ private:
 
 class DefaultBluetoothGattCharacteristic : protected LogSetup, public BluetoothGattCharacteristic {
 public:
-    DefaultBluetoothGattCharacteristic(const BluetoothGattServicePtr &service, uint16_t handle, uuid_t uuid,
+    DefaultBluetoothGattCharacteristic(const BluetoothGattServicePtr &service, uint16_t handle, Uuid uuid,
                                        uint8_t properties, uint16_t valueHandle)
-        : LogSetup("BluetoothGattCharacteristic"), service(service), handle(handle), uuid(uuid),
-          properties(properties), valueHandle(valueHandle) {
+            : LogSetup("BluetoothGattCharacteristic"), service(service), handle(handle), uuid(uuid),
+              properties(properties), valueHandle(valueHandle) {
     }
 
-    virtual ~DefaultBluetoothGattCharacteristic() {
-    }
+    ~DefaultBluetoothGattCharacteristic() override = default;
 
-    BluetoothGattServicePtr getService() const {
+    BluetoothGattServicePtr getService() const override {
         return service;
     }
 
-    uint16_t getHandle() const {
+    uint16_t getHandle() const override {
         return handle;
     }
 
-    const uuid_t getUuid() const {
+    const Uuid getUuid() const override {
         return uuid;
     }
 
-    uint8_t getProperties() const {
+    uint8_t getProperties() const override {
         return properties;
     }
 
-    uint16_t getValueHandle() const {
+    uint16_t getValueHandle() const override {
         return valueHandle;
     }
 
 protected:
     BluetoothGattServicePtr service;
     uint16_t handle;
-    uuid_t uuid;
+    Uuid uuid;
     uint8_t properties;
     uint16_t valueHandle;
 };
 
-template<typename DeviceType, typename CharacteristicType>
+template<typename DeviceType>
 class DefaultBluetoothGattService : public BluetoothGattService {
 public:
-    DefaultBluetoothGattService(DeviceType &device, const uuid_t uuid, const uint16_t handle,
+    DefaultBluetoothGattService(DeviceType &device, const Uuid uuid, const uint16_t handle,
                                 const uint16_t endGroupHandle)
         : device(device), uuid(uuid), handle(handle), endGroupHandle(endGroupHandle) {
     }
@@ -122,48 +120,47 @@ public:
           endGroupHandle(std::move(o.endGroupHandle)), characteristics(std::move(o.characteristics)) {
     }
 
-    virtual ~DefaultBluetoothGattService() {
-    }
+    ~DefaultBluetoothGattService() override = default;
 
-    virtual BluetoothDevice &getDevice() const {
+    BluetoothDevice &getDevice() const override {
         return device;
     }
 
-    virtual uuid_t getUuid() const {
+    Uuid getUuid() const override {
         return uuid;
     }
 
-    virtual uint16_t getHandle() const {
+    uint16_t getHandle() const override {
         return handle;
     }
 
-    virtual uint16_t getEndGroupHandle() const {
+    uint16_t getEndGroupHandle() const override {
         return endGroupHandle;
     }
 
-    virtual vector<shared_ptr<BluetoothGattCharacteristic>> getCharacteristics() const {
+    vector<shared_ptr<BluetoothGattCharacteristic>> getCharacteristics() const override {
         vector<shared_ptr<BluetoothGattCharacteristic>> cs(characteristics.size());
         std::copy(begin(characteristics), end(characteristics), begin(cs));
         return cs;
     }
 
-    virtual void addCharacteristic(shared_ptr<CharacteristicType> &&characteristic) {
+    virtual void addCharacteristic(shared_ptr<BluetoothGattCharacteristic> &&characteristic) {
         characteristics.emplace_back(characteristic);
     }
 
-    virtual o<shared_ptr<BluetoothGattCharacteristic>> findCharacteristic(uuid_t uuid) {
+    o<shared_ptr<BluetoothGattCharacteristic>> findCharacteristic(Uuid uuid) override {
         for (auto &c: characteristics) {
-            if (memcmp(c->getUuid().data, uuid.data, 16) == 0) {
-                return o<shared_ptr<BluetoothGattCharacteristic>>(c);
+            if (c->getUuid() == uuid) {
+                return {c};
             }
         }
 
-        return o<shared_ptr<BluetoothGattCharacteristic>>();
+        return {};
     }
 
 protected:
     DeviceType &device;
-    const uuid_t uuid;
+    const Uuid uuid;
     const uint16_t handle;
     const uint16_t endGroupHandle;
     vector<shared_ptr<BluetoothGattCharacteristic>> characteristics;
@@ -172,7 +169,7 @@ protected:
 template<class _D, class _S>
 class DefaultBluetoothGatt : protected LogSetup, public BluetoothGatt {
 public:
-    virtual _D &getDevice() const {
+    _D &getDevice() const override {
         return device;
     }
 
@@ -180,15 +177,15 @@ public:
 //        return CollectionImpl<BluetoothGattService, vector<_S>>(services);
 //    }
 
-    virtual vector<shared_ptr<BluetoothGattService>> getServices() const {
+    vector<shared_ptr<BluetoothGattService>> getServices() const override {
         vector<shared_ptr<BluetoothGattService>> ss(services.size());
         std::copy(begin(services), end(services), begin(ss));
         return ss;
     }
 
-    virtual o <BluetoothGattServicePtr> findService(uuid_t uuid) {
+    o <BluetoothGattServicePtr> findService(Uuid uuid) override {
         for (auto &s: services) {
-            if (memcmp(s->getUuid().data, uuid.data, 16) == 0) {
+            if (s->getUuid() == uuid) {
                 return o<shared_ptr<BluetoothGattService>>(s);
             }
         }
@@ -201,12 +198,10 @@ public:
     }
 
 protected:
-    DefaultBluetoothGatt(_D &device) : LogSetup("BluetoothGatt"), device(device) {
+    explicit DefaultBluetoothGatt(_D &device) : LogSetup("BluetoothGatt"), device(device) {
     }
 
-    virtual ~DefaultBluetoothGatt() {
-//        removeServices();
-    }
+    ~DefaultBluetoothGatt() override = default;
 
     void removeServices() {
 //        for (auto s: services) {
@@ -223,11 +218,11 @@ template<class A>
 class DefaultBluetoothDevice : protected LogSetup, public BluetoothDevice {
 public:
 
-    virtual Mac const &getMac() override {
+    Mac const &getMac() override {
         return mac;
     }
 
-    virtual A &getAdapter() override {
+    A &getAdapter() override {
         return adapter;
     }
 
@@ -240,7 +235,7 @@ protected:
         LogSetup("BluetoothDevice"), adapter(std::move(o.adapter)), mac(std::move(o.mac)) {
     }
 
-    virtual ~DefaultBluetoothDevice() {
+    ~DefaultBluetoothDevice() override {
         removeServices();
     }
 
@@ -259,7 +254,7 @@ protected:
 class DefaultBluetoothAdapter : protected LogSetup, public BluetoothAdapter {
 public:
 protected:
-    DefaultBluetoothAdapter(Mac &mac) :
+    explicit DefaultBluetoothAdapter(Mac &mac) :
         LogSetup("BluetoothAdapter"), mac(mac) {
     }
 
diff --git a/ble/LinuxBluetooth.cpp b/ble/LinuxBluetooth.cpp
index d4073d1..7e7c9dc 100644
--- a/ble/LinuxBluetooth.cpp
+++ b/ble/LinuxBluetooth.cpp
@@ -28,9 +28,9 @@ class LinuxBluetoothAdapter;
 
 class LinuxBluetoothManager;
 
-class LinuxBluetoothGattService : public DefaultBluetoothGattService<LinuxBluetoothDevice, DefaultBluetoothGattCharacteristic> {
+class LinuxBluetoothGattService : public DefaultBluetoothGattService<LinuxBluetoothDevice> {
 public:
-    LinuxBluetoothGattService(LinuxBluetoothDevice &device, const uuid_t uuid, const uint16_t handle,
+    LinuxBluetoothGattService(LinuxBluetoothDevice &device, const Uuid uuid, const uint16_t handle,
                               const uint16_t endGroupHandle) : DefaultBluetoothGattService(device, uuid, handle, endGroupHandle) {
     };
 
@@ -41,7 +41,7 @@ class LinuxBluetoothAdapter final : public DefaultBluetoothAdapter {
 public:
     LinuxBluetoothAdapter(int hciDeviceId, Mac &mac);
 
-    ~LinuxBluetoothAdapter();
+    ~LinuxBluetoothAdapter() override;
 
     LinuxBluetoothAdapter(const LinuxBluetoothAdapter &) = delete;
 
@@ -67,9 +67,9 @@ private:
 class LinuxBluetoothDevice final : public DefaultBluetoothDevice<LinuxBluetoothAdapter>,
                                    public std::enable_shared_from_this<LinuxBluetoothDevice> {
 public:
-    LinuxBluetoothDevice(LinuxBluetoothAdapter &adapter, Mac &mac);
+    explicit LinuxBluetoothDevice(LinuxBluetoothAdapter &adapter, Mac &mac);
 
-    virtual ~LinuxBluetoothDevice();
+    ~LinuxBluetoothDevice() override;
 
     LinuxBluetoothDevice(const LinuxBluetoothDevice &) = delete;
 
@@ -83,9 +83,9 @@ private:
 
 class LinuxBluetoothGatt final : public DefaultBluetoothGatt<LinuxBluetoothDevice, LinuxBluetoothGattService> {
 public:
-    LinuxBluetoothGatt(LinuxBluetoothDevice &device);
+    explicit LinuxBluetoothGatt(LinuxBluetoothDevice &device);
 
-    ~LinuxBluetoothGatt();
+    ~LinuxBluetoothGatt() override;
 
     LinuxBluetoothGatt(const LinuxBluetoothGatt&) = delete;
 
@@ -110,6 +110,7 @@ private:
 
     ByteBuffer writeAndRead(ByteBuffer &out, shared_ptr<uint8_t> buffer, size_t size);
 
+
     int l2cap;
 };
 
@@ -124,7 +125,7 @@ string errnoAsString() {
 // -----------------------------------------------------------------------
 
 Mac parseMac(bdaddr_t &a) {
-    return Mac(a.b[5], a.b[4], a.b[3], a.b[2], a.b[1], a.b[0]);
+    return Mac{a.b[5], a.b[4], a.b[3], a.b[2], a.b[1], a.b[0]};
 }
 
 // -----------------------------------------------------------------------
@@ -137,16 +138,13 @@ LinuxBluetoothDevice::LinuxBluetoothDevice(LinuxBluetoothAdapter &adapter, Mac &
 
 LinuxBluetoothDevice::~LinuxBluetoothDevice() {
     LOG_DEBUG("Closing device " << mac.str());
-    if (gatt) {
-        delete gatt;
-    }
+
+    delete gatt;
 };
 
 shared_ptr<BluetoothGatt> LinuxBluetoothDevice::connectGatt() {
     // Make sure that we close the old connection and create a new one when the user asks for it.
-    if (gatt) {
-        delete gatt;
-    }
+    delete gatt;
 
     gatt = new LinuxBluetoothGatt(*this);
 
@@ -158,7 +156,7 @@ shared_ptr<BluetoothGatt> LinuxBluetoothDevice::connectGatt() {
 // -----------------------------------------------------------------------
 
 LinuxBluetoothGatt::LinuxBluetoothGatt(LinuxBluetoothDevice &device) :
-        DefaultBluetoothGatt(device) {
+        DefaultBluetoothGatt(device), l2cap() {
     connect();
 }
 
@@ -171,7 +169,7 @@ bool LinuxBluetoothGatt::isConnected() const {
 }
 
 void LinuxBluetoothGatt::connect() {
-    struct sockaddr_l2 addr;
+    struct sockaddr_l2 addr{};
 
     LOG_DEBUG("connect: mac=" << device.getMac().str());
 
@@ -191,7 +189,7 @@ void LinuxBluetoothGatt::connect() {
         throw BluetoothException(&device, "bind(): " + errnoAsString());
     }
 
-    struct bt_security btsec;
+    struct bt_security btsec{};
     memset(&btsec, 0, sizeof(btsec));
     btsec.level = BT_SECURITY_LOW;
     if (setsockopt(l2cap, SOL_BLUETOOTH, BT_SECURITY, &btsec, sizeof(btsec)) != 0) {
@@ -225,40 +223,21 @@ void LinuxBluetoothGatt::disconnect() {
     close(l2cap);
 }
 
-uuid_t readUuid(BluetoothDevice *device, const ByteBuffer &bytes) {
+Uuid readUuid(BluetoothDevice *device, const ByteBuffer &bytes) {
     size_t bytesLeft = bytes.getBytesLeft();
 
-    uuid_t u;
-
     if (bytesLeft == 2) {
         uint8_t bs[16] = BLUETOOTH_UUID_INITIALIZER;
         bs[2] = bytes.get8(1);
         bs[3] = bytes.get8(0);
-        memcpy(&u, bs, 16);
+
+        return Uuid(bs);
     } else if (bytesLeft == 16) {
-        uint8_t bs[16];
-        bs[15] = bytes.get8(0);
-        bs[14] = bytes.get8(1);
-        bs[13] = bytes.get8(2);
-        bs[12] = bytes.get8(3);
-        bs[11] = bytes.get8(4);
-        bs[10] = bytes.get8(5);
-        bs[9] = bytes.get8(6);
-        bs[8] = bytes.get8(7);
-        bs[7] = bytes.get8(8);
-        bs[6] = bytes.get8(9);
-        bs[5] = bytes.get8(10);
-        bs[4] = bytes.get8(11);
-        bs[3] = bytes.get8(12);
-        bs[2] = bytes.get8(13);
-        bs[1] = bytes.get8(14);
-        bs[0] = bytes.get8(15);
-        memcpy(&u, bs, 16);
+        return {bytes.get8(0), bytes.get8(1), bytes.get8(2), bytes.get8(3), bytes.get8(4), bytes.get8(5), bytes.get8(6), bytes.get8(7),
+                bytes.get8(8), bytes.get8(9), bytes.get8(10), bytes.get8(11), bytes.get8(12), bytes.get8(13), bytes.get8(14), bytes.get8(15)};
     } else {
         throw BluetoothException(device, "Unexpected bytes left: " + to_string(bytesLeft));
     }
-
-    return u;
 }
 
 void LinuxBluetoothGatt::writeValue(const BluetoothGattCharacteristicPtr &c, const ByteBuffer &bytes) {
@@ -302,7 +281,7 @@ void LinuxBluetoothGatt::discoverServices() {
         vector<AttributeData> values = discoverServices(startHandle);
 
         // Shouldn't happen, but you never know.
-        if (values.size() == 0) {
+        if (values.empty()) {
             break;
         }
 
@@ -315,7 +294,7 @@ void LinuxBluetoothGatt::discoverServices() {
 //                        ", endGroupHandle: 0x" << hex << setw(4) << setfill('0') << endGroupHandle <<
 //                        ", value: " << data.value.toString();
 
-            uuid_t u = readUuid(&device, data.value);
+            auto u = readUuid(&device, data.value);
 
             addService(make_shared<LinuxBluetoothGattService>(device, u, data.handle, endGroupHandle));
         }
@@ -344,7 +323,7 @@ void LinuxBluetoothGatt::discoverServices() {
     do {
         vector<AttributeData> values = discoverCharacteristics(startHandle, 0xffff);
 
-        if (values.size() == 0) {
+        if (values.empty()) {
             break;
         }
 
@@ -360,7 +339,7 @@ void LinuxBluetoothGatt::discoverServices() {
 
             uint8_t properties = c.value.read8();
             uint16_t valueHandle = c.value.read16le();
-            uuid_t uuid = readUuid(&device, c.value);
+            auto uuid = readUuid(&device, c.value);
 
 //            D << "characteristic: handle: " << setw(2) << setfill('0') << hex << (int) c.handle <<
 //                        ", properties: " << setw(2) << setfill('0') << hex << (int) properties <<
@@ -435,7 +414,7 @@ vector<AttributeData> LinuxBluetoothGatt::discoverCharacteristics(uint16_t start
 // -----------------------------------------------------------------------
 
 LinuxBluetoothAdapter::LinuxBluetoothAdapter(int hciDeviceId, Mac &mac) : DefaultBluetoothAdapter(mac),
-        scanning(false) {
+        scanning(false), hciFilter() {
     LOG_DEBUG("hciDeviceId=" << hciDeviceId);
 
     this->hciDeviceId = hciDeviceId;
@@ -466,7 +445,7 @@ LinuxBluetoothAdapter::~LinuxBluetoothAdapter() {
 }
 
 void LinuxBluetoothAdapter::startScan() {
-    struct hci_dev_info di;
+    struct hci_dev_info di{};
 
     if (hci_devinfo(hciDeviceId, &di) < 0) {
         throw BluetoothException(this, "Could not query device info: " + errnoAsString());
@@ -541,11 +520,11 @@ void LinuxBluetoothAdapter::runScan(std::function<void(const shared_ptr<Bluetoot
         FD_SET(hciSocket, &rfds);
 
         // Linux can change tv, so it has to be reinitialized
-        struct timeval tv;
+        struct timeval tv{};
         tv.tv_sec = 1;
         tv.tv_usec = 0;
 
-        int selected = select(hciSocket + 1, &rfds, NULL, NULL, &tv);
+        int selected = select(hciSocket + 1, &rfds, nullptr, nullptr, &tv);
 
         if (selected == -1) {
             // Someone stopped the scan, so this is no problem
@@ -564,13 +543,13 @@ void LinuxBluetoothAdapter::runScan(std::function<void(const shared_ptr<Bluetoot
         unsigned char hciEventBuf[HCI_MAX_EVENT_SIZE];
 
         ssize_t len = read(hciSocket, hciEventBuf, sizeof(hciEventBuf));
-        evt_le_meta_event *metaEvent = (evt_le_meta_event *) (hciEventBuf + (1 + HCI_EVENT_HDR_SIZE));
+        auto *metaEvent = (evt_le_meta_event *) (hciEventBuf + (1 + HCI_EVENT_HDR_SIZE));
         len -= (1 + HCI_EVENT_HDR_SIZE);
 
         LOG_DEBUG("metaEvent->subevent = " << std::hex << (int) metaEvent->subevent);
 
         if (metaEvent->subevent == EVT_LE_ADVERTISING_REPORT) {
-            le_advertising_info *advertisingInfo = (le_advertising_info *) (metaEvent->data + 1);
+            auto *advertisingInfo = (le_advertising_info *) (metaEvent->data + 1);
 
             Mac mac = parseMac(advertisingInfo->bdaddr);
 
@@ -605,7 +584,7 @@ shared_ptr<BluetoothAdapter> getAdapterImpl(string name) {
         throw BluetoothException("Bad device name: " + name);
     }
 
-    struct hci_dev_info di;
+    struct hci_dev_info di{};
     if (hci_devinfo(hciDevice, &di) < 0) {
         throw BluetoothException("Could not query device info: " + errnoAsString());
     }
-- 
cgit v1.2.3