summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorZachary T Welch <zw@superlucidity.net>2009-11-16 03:33:22 -0800
committerZachary T Welch <zw@superlucidity.net>2009-11-16 09:58:11 -0800
commit10cce4a5fe85bfd680bc338c900b0033d7174b6a (patch)
tree545cfc92a176b4cc353e35d3f1f96ef344259df2
parent0535a9245632e2cf12d8eaae8c4a9b1cc0bc66c6 (diff)
downloadopenocd+libswd-10cce4a5fe85bfd680bc338c900b0033d7174b6a.tar.gz
openocd+libswd-10cce4a5fe85bfd680bc338c900b0033d7174b6a.tar.bz2
openocd+libswd-10cce4a5fe85bfd680bc338c900b0033d7174b6a.tar.xz
openocd+libswd-10cce4a5fe85bfd680bc338c900b0033d7174b6a.zip
armv7m: make core reg read/write use unsigned
Eliminate redundant check that gets covered by using unsigned type. Created to eliminate noise from subsequent patches, but this kind of conversion will be beneficial in similar ways throughout the tree.
-rw-r--r--src/target/armv7m.c8
-rw-r--r--src/target/armv7m.h4
2 files changed, 6 insertions, 6 deletions
diff --git a/src/target/armv7m.c b/src/target/armv7m.c
index d8718f9e..f6127e89 100644
--- a/src/target/armv7m.c
+++ b/src/target/armv7m.c
@@ -236,14 +236,14 @@ static int armv7m_set_core_reg(struct reg *reg, uint8_t *buf)
return ERROR_OK;
}
-static int armv7m_read_core_reg(struct target *target, int num)
+static int armv7m_read_core_reg(struct target *target, unsigned num)
{
uint32_t reg_value;
int retval;
struct armv7m_core_reg * armv7m_core_reg;
struct armv7m_common *armv7m = target_to_armv7m(target);
- if ((num < 0) || (num >= ARMV7M_NUM_REGS))
+ if (num >= ARMV7M_NUM_REGS)
return ERROR_INVALID_ARGUMENTS;
armv7m_core_reg = armv7m->core_cache->reg_list[num].arch_info;
@@ -255,14 +255,14 @@ static int armv7m_read_core_reg(struct target *target, int num)
return retval;
}
-static int armv7m_write_core_reg(struct target *target, int num)
+static int armv7m_write_core_reg(struct target *target, unsigned num)
{
int retval;
uint32_t reg_value;
struct armv7m_core_reg *armv7m_core_reg;
struct armv7m_common *armv7m = target_to_armv7m(target);
- if ((num < 0) || (num >= ARMV7M_NUM_REGS))
+ if (num >= ARMV7M_NUM_REGS)
return ERROR_INVALID_ARGUMENTS;
reg_value = buf_get_u32(armv7m->core_cache->reg_list[num].value, 0, 32);
diff --git a/src/target/armv7m.h b/src/target/armv7m.h
index 7f8190bf..dba9a3bd 100644
--- a/src/target/armv7m.h
+++ b/src/target/armv7m.h
@@ -103,8 +103,8 @@ struct armv7m_common
int (*load_core_reg_u32)(struct target *target, enum armv7m_regtype type, uint32_t num, uint32_t *value);
int (*store_core_reg_u32)(struct target *target, enum armv7m_regtype type, uint32_t num, uint32_t value);
/* register cache to processor synchronization */
- int (*read_core_reg)(struct target *target, int num);
- int (*write_core_reg)(struct target *target, int num);
+ int (*read_core_reg)(struct target *target, unsigned num);
+ int (*write_core_reg)(struct target *target, unsigned num);
int (*examine_debug_reason)(struct target *target);
void (*post_debug_entry)(struct target *target);