diff options
| -rw-r--r-- | src/target/arm7tdmi.c | 7 | ||||
| -rw-r--r-- | src/target/arm_adi_v5.c | 6 |
2 files changed, 13 insertions, 0 deletions
diff --git a/src/target/arm7tdmi.c b/src/target/arm7tdmi.c index 5f45ad99..647e68b9 100644 --- a/src/target/arm7tdmi.c +++ b/src/target/arm7tdmi.c @@ -372,6 +372,13 @@ void arm7tdmi_change_to_arm(target_t *target, u32 *r0, u32 *pc) *pc -= 0xa; } + +/* FIX!!! is this a potential performance bottleneck w.r.t. requiring too many + * roundtrips when jtag_execute_queue() has a large overhead(e.g. for USB)s? + * + * The solution is to arrange for a large out/in scan in this loop and + * and convert data afterwards. + */ void arm7tdmi_read_core_regs(target_t *target, u32 mask, u32* core_regs[16]) { int i; diff --git a/src/target/arm_adi_v5.c b/src/target/arm_adi_v5.c index c1555d9f..871caefc 100644 --- a/src/target/arm_adi_v5.c +++ b/src/target/arm_adi_v5.c @@ -867,6 +867,12 @@ int mem_ap_read_buf_u16(swjdp_common_t *swjdp, u8 *buffer, int count, u32 addres return retval; } +/* FIX!!! is this a potential performance bottleneck w.r.t. requiring too many + * roundtrips when jtag_execute_queue() has a large overhead(e.g. for USB)s? + * + * The solution is to arrange for a large out/in scan in this loop and + * and convert data afterwards. + */ int mem_ap_read_buf_packed_u8(swjdp_common_t *swjdp, u8 *buffer, int count, u32 address) { u32 invalue; |