From f4788652e45662d1e43933dc0620561bc4cddae0 Mon Sep 17 00:00:00 2001 From: David Brownell Date: Tue, 17 Nov 2009 09:06:45 -0800 Subject: target: simplify register get/set ops No need to indirect from registered integers to pointers. Just stash the pointers directly in the register struct, and don't even bother registering. This is a small code shrink, speeds register access just a smidgeon, and gets rid of another rude exit() path. Signed-off-by: David Brownell --- src/target/mips32.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) (limited to 'src/target/mips32.c') diff --git a/src/target/mips32.c b/src/target/mips32.c index 1315744c..f986079d 100644 --- a/src/target/mips32.c +++ b/src/target/mips32.c @@ -97,11 +97,8 @@ struct reg mips32_gdb_dummy_fp_reg = .valid = 1, .size = 32, .arch_info = NULL, - .arch_type = 0, }; -int mips32_core_reg_arch_type = -1; - int mips32_get_core_reg(struct reg *reg) { int retval; @@ -278,6 +275,11 @@ int mips32_arch_state(struct target *target) return ERROR_OK; } +static const struct reg_arch_type mips32_reg_type = { + .get = mips32_get_core_reg, + .set = mips32_set_core_reg, +}; + struct reg_cache *mips32_build_reg_cache(struct target *target) { /* get pointers to arch-specific information */ @@ -290,9 +292,6 @@ struct reg_cache *mips32_build_reg_cache(struct target *target) struct mips32_core_reg *arch_info = malloc(sizeof(struct mips32_core_reg) * num_regs); int i; - if (mips32_core_reg_arch_type == -1) - mips32_core_reg_arch_type = register_reg_arch_type(mips32_get_core_reg, mips32_set_core_reg); - register_init_dummy(&mips32_gdb_dummy_fp_reg); /* Build the process context cache */ @@ -313,7 +312,7 @@ struct reg_cache *mips32_build_reg_cache(struct target *target) reg_list[i].value = calloc(1, 4); reg_list[i].dirty = 0; reg_list[i].valid = 0; - reg_list[i].arch_type = mips32_core_reg_arch_type; + reg_list[i].type = &mips32_reg_type; reg_list[i].arch_info = &arch_info[i]; } -- cgit v1.2.3