From 7269ba5eb6c4c0e3b8dfceba9d5f2c2f4dfc1618 Mon Sep 17 00:00:00 2001 From: David Brownell Date: Mon, 9 Nov 2009 14:46:23 -0800 Subject: Revert "target: add target->type->has_mmu fn" This patch introduced a bug preventing flash writes from working on Cortex-M3 targets like the STM32. Moreover, it's the wrong approach for handling no-MMU targets. The right way to handle no-MMU targets is to provide accessors for physical addresses, and use them everywhere; and any code which tries to work with virtual-to-physical mappings should use a identity mapping (which can be defaulted). And ... we can tell if a target has an MMU by seeing if it's got an mmu() method. No such methood means no MMU. Signed-off-by: David Brownell --- src/target/target_type.h | 8 -------- 1 file changed, 8 deletions(-) (limited to 'src/target/target_type.h') diff --git a/src/target/target_type.h b/src/target/target_type.h index 23ed40e0..dd469db1 100644 --- a/src/target/target_type.h +++ b/src/target/target_type.h @@ -199,16 +199,8 @@ struct target_type_s */ int (*write_phys_memory)(struct target_s *target, uint32_t phys_address, uint32_t size, uint32_t count, uint8_t *buffer); - /* returns true if the mmu is enabled. Default implementation returns error. */ int (*mmu)(struct target_s *target, int *enabled); - /* returns true if the target has an mmu. This can only be - determined after the target has been examined. - - Default implementation returns success and has_mmu==true. - */ - int (*has_mmu)(struct target_s *target, bool *has_mmu); - /* Read coprocessor - arm specific. Default implementation returns error. */ int (*mrc)(struct target_s *target, int cpnum, uint32_t op1, uint32_t op2, uint32_t CRn, uint32_t CRm, uint32_t *value); -- cgit v1.2.3