From 63a26b421b1731df5826a157ea633b9d2c02aaee Mon Sep 17 00:00:00 2001 From: Zachary T Welch Date: Tue, 10 Nov 2009 03:12:21 -0800 Subject: use COMMAND_HELPER for command helper functions Define the numerous helpers that inherit command handler parameters using the COMMAND_HELPER macro. --- src/target/arm11.c | 5 ++--- src/target/etm.c | 7 +++---- src/target/target.c | 9 ++++----- 3 files changed, 9 insertions(+), 12 deletions(-) (limited to 'src/target') diff --git a/src/target/arm11.c b/src/target/arm11.c index 098b0afa..949c9475 100644 --- a/src/target/arm11.c +++ b/src/target/arm11.c @@ -1991,8 +1991,7 @@ static int arm11_build_reg_cache(target_t *target) return ERROR_OK; } -static int arm11_handle_bool(struct command_context_s *cmd_ctx, - char *cmd, char **args, int argc, bool * var, char * name) +static COMMAND_HELPER(arm11_handle_bool, bool *var, char *name) { if (argc == 0) { @@ -2143,7 +2142,7 @@ static int arm11_mcr(target_t *target, int cpnum, return arm11_mrc_inner(target, cpnum, op1, op2, CRn, CRm, &value, false); } -static int arm11_handle_etm_read_write(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc, bool read) +static COMMAND_HELPER(arm11_handle_etm_read_write, bool read) { if (argc != (read ? 2 : 3)) { diff --git a/src/target/etm.c b/src/target/etm.c index 0fc92491..df029042 100644 --- a/src/target/etm.c +++ b/src/target/etm.c @@ -1176,9 +1176,8 @@ static int etmv1_analyze_trace(etm_context_t *ctx, struct command_context_s *cmd return ERROR_OK; } -static int handle_etm_tracemode_command_update( - struct command_context_s *cmd_ctx, - char **args, etmv1_tracemode_t *mode) +static COMMAND_HELPER(handle_etm_tracemode_command_update, + etmv1_tracemode_t *mode) { etmv1_tracemode_t tracemode; @@ -1272,7 +1271,7 @@ COMMAND_HANDLER(handle_etm_tracemode_command) case 0: break; case 4: - handle_etm_tracemode_command_update(cmd_ctx, args, &tracemode); + handle_etm_tracemode_command_update(cmd_ctx, cmd, args, argc, &tracemode); break; default: command_print(cmd_ctx, "usage: configure trace mode " diff --git a/src/target/target.c b/src/target/target.c index 401f4dfb..26c20cf3 100644 --- a/src/target/target.c +++ b/src/target/target.c @@ -2363,8 +2363,7 @@ COMMAND_HANDLER(handle_mw_command) } -static int parse_load_image_command_args(struct command_context_s *cmd_ctx, - char **args, int argc, image_t *image, +static COMMAND_HELPER(parse_load_image_command_args, image_t *image, uint32_t *min_address, uint32_t *max_address) { if (argc < 1 || argc > 5) @@ -2411,7 +2410,7 @@ COMMAND_HANDLER(handle_load_image_command) int i; image_t image; - int retval = parse_load_image_command_args(cmd_ctx, args, argc, + int retval = parse_load_image_command_args(cmd_ctx, cmd, args, argc, &image, &min_address, &max_address); if (ERROR_OK != retval) return retval; @@ -2555,7 +2554,7 @@ COMMAND_HANDLER(handle_dump_image_command) return retval; } -static int handle_verify_image_command_internal(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc, int verify) +static COMMAND_HELPER(handle_verify_image_command_internal, int verify) { uint8_t *buffer; uint32_t buf_cnt; @@ -4548,7 +4547,7 @@ COMMAND_HANDLER(handle_fast_load_image_command) image_t image; - int retval = parse_load_image_command_args(cmd_ctx, args, argc, + int retval = parse_load_image_command_args(cmd_ctx, cmd, args, argc, &image, &min_address, &max_address); if (ERROR_OK != retval) return retval; -- cgit v1.2.3