From c9e58238c3b1ae181a7d54bc5255ef98771493c2 Mon Sep 17 00:00:00 2001
From: Antonio Borneo <borneo.antonio@gmail.com>
Date: Wed, 14 Apr 2010 16:32:30 +0800
Subject: NOR/CFI: fix order of arguments check

Syntax of "flash bank" command requires:
- chip_width as CMD_ARGV[3]
- bus_width  as CMD_ARGV[4]
Actual code swaps the arguments.
Bug has no run time impact since wrong variables
are only used to check value and both are checked
against same constraint.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
---
 src/flash/nor/cfi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

(limited to 'src/flash')

diff --git a/src/flash/nor/cfi.c b/src/flash/nor/cfi.c
index 4dad7b6f..325dce90 100644
--- a/src/flash/nor/cfi.c
+++ b/src/flash/nor/cfi.c
@@ -599,8 +599,8 @@ FLASH_BANK_COMMAND_HANDLER(cfi_flash_bank_command)
 	}
 
 	uint16_t chip_width, bus_width;
-	COMMAND_PARSE_NUMBER(u16, CMD_ARGV[3], bus_width);
-	COMMAND_PARSE_NUMBER(u16, CMD_ARGV[4], chip_width);
+	COMMAND_PARSE_NUMBER(u16, CMD_ARGV[3], chip_width);
+	COMMAND_PARSE_NUMBER(u16, CMD_ARGV[4], bus_width);
 
 	if ((chip_width > CFI_MAX_CHIP_WIDTH)
 			|| (bus_width > CFI_MAX_BUS_WIDTH))
-- 
cgit v1.2.3