From 2a8aa3b7efb590cabd7ee930dbb68fd64e028099 Mon Sep 17 00:00:00 2001 From: David Brownell Date: Sun, 25 Oct 2009 13:06:47 -0700 Subject: xscale: always reload handler after reset Remove needless debug handler state. - "handler_installed" became wrong as soon as the second TRST+SRST reset was issued ... so the handler was never reloaded after the reset removed it from the mini-icache. This fixes the bug where subsequent resets fail on PXA255 (if the first one even worked, which is uncommon). Other XScale chips would have problems too; PXA270 seems to have, IXP425 maybe not. - "handler_running" was never tested; it's pointless. Plus a related bugfix: invalidate OpenOCD's ARM register cache on reset. It was no more valid than the XScale's mini-icache. (Though ... such invalidations might be better done in "SRST asserted" callbacks.) Signed-off-by: David Brownell --- src/target/xscale.h | 2 -- 1 file changed, 2 deletions(-) (limited to 'src/target/xscale.h') diff --git a/src/target/xscale.h b/src/target/xscale.h index a5d83ee6..4b34cf88 100644 --- a/src/target/xscale.h +++ b/src/target/xscale.h @@ -86,8 +86,6 @@ typedef struct xscale_common_s reg_cache_t *reg_cache; /* current state of the debug handler */ - int handler_installed; - int handler_running; uint32_t handler_address; /* target-endian buffers with exception vectors */ -- cgit v1.2.3