summaryrefslogtreecommitdiff
path: root/bitbake/lib/bb
diff options
context:
space:
mode:
authorBernhard Reutner-Fischer <rep.dot.nop@gmail.com>2011-01-03 20:57:22 +0100
committerRichard Purdie <rpurdie@linux.intel.com>2011-01-04 15:00:18 +0000
commitaae85325289a83d21606621310894d5d6f56b50a (patch)
tree6037e272963f3c4a68e567db7167a68b0914d8c0 /bitbake/lib/bb
parentc9d4807662494aa313c9b5b3bb5de6f8a25d32d3 (diff)
downloadopenembedded-core-aae85325289a83d21606621310894d5d6f56b50a.tar.gz
openembedded-core-aae85325289a83d21606621310894d5d6f56b50a.tar.bz2
openembedded-core-aae85325289a83d21606621310894d5d6f56b50a.tar.xz
openembedded-core-aae85325289a83d21606621310894d5d6f56b50a.zip
cache: defer marking fn as clean
Only mark fn as clean if it is clean. This saves us from removing (prematurely added) fn from our clean set and saves me a few percent of runtime (and misleading debugging output from remove()). (Bitbake rev: 884365228fcaac07421ac1440d4946693fb628c5) Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com> Signed-off-by: Richard Purdie <rpurdie@linux.intel.com>
Diffstat (limited to 'bitbake/lib/bb')
-rw-r--r--bitbake/lib/bb/cache.py5
1 files changed, 1 insertions, 4 deletions
diff --git a/bitbake/lib/bb/cache.py b/bitbake/lib/bb/cache.py
index 2f8935076..c477501d6 100644
--- a/bitbake/lib/bb/cache.py
+++ b/bitbake/lib/bb/cache.py
@@ -347,13 +347,9 @@ class Cache(object):
self.checked.add(fn)
- # Pretend we're clean so getVar works
- self.clean.add(fn)
-
# File isn't in depends_cache
if not fn in self.depends_cache:
logger.debug(2, "Cache: %s is not cached", fn)
- self.remove(fn)
return False
mtime = bb.parse.cached_mtime_noerror(fn)
@@ -409,6 +405,7 @@ class Cache(object):
self.clean.remove(fn)
return False
+ self.clean.add(fn)
return True
def remove(self, fn):