diff options
| author | Nitin A Kamble <nitin.a.kamble@intel.com> | 2011-01-20 17:15:36 -0800 |
|---|---|---|
| committer | Saul Wold <sgw@linux.intel.com> | 2011-01-24 14:09:12 -0800 |
| commit | 1ef70572f9480d14e945aae5197d24d1ce1bdf9c (patch) | |
| tree | 068c487f2ec77739be3b52326a2279e164858c4a /meta/recipes-multimedia/musicbrainz/libmusicbrainz-3.0.3 | |
| parent | 57392afdbb0daf79a42c9a7a6814145715582289 (diff) | |
| download | openembedded-core-1ef70572f9480d14e945aae5197d24d1ce1bdf9c.tar.gz openembedded-core-1ef70572f9480d14e945aae5197d24d1ce1bdf9c.tar.bz2 openembedded-core-1ef70572f9480d14e945aae5197d24d1ce1bdf9c.tar.xz openembedded-core-1ef70572f9480d14e945aae5197d24d1ce1bdf9c.zip | |
libmusicbrainz: revert the dso_linking_change patch as the new linker fixes it
The newer binutils recipe of version 2.21 has a fix for ld which avoids an
issue where weak symbols like pthread_cancel were causing linking to fail when
--no-add-as-needed parameter was passed to ld.
See more information here: http://bugs.debian.org/591405
This makes some of the fixes for breakage after gcc dso linking change
unnecessary and this is one of them.
Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
Diffstat (limited to 'meta/recipes-multimedia/musicbrainz/libmusicbrainz-3.0.3')
| -rw-r--r-- | meta/recipes-multimedia/musicbrainz/libmusicbrainz-3.0.3/dso_linking_change_build_fix.patch | 29 |
1 files changed, 0 insertions, 29 deletions
diff --git a/meta/recipes-multimedia/musicbrainz/libmusicbrainz-3.0.3/dso_linking_change_build_fix.patch b/meta/recipes-multimedia/musicbrainz/libmusicbrainz-3.0.3/dso_linking_change_build_fix.patch deleted file mode 100644 index 5f0cce2e1..000000000 --- a/meta/recipes-multimedia/musicbrainz/libmusicbrainz-3.0.3/dso_linking_change_build_fix.patch +++ /dev/null @@ -1,29 +0,0 @@ -dso build fix: -With a dso patch for gcc, which prevents automatic linking of unspecified libraries, -this recipe fails to compile with this error: - -| Linking CXX executable cdlookup^M -| cd /disk0/pokybuild/build1/tmp/work/i586-poky-linux/libmusicbrainz-3.0.3-r0/libmusicbrainz-3.0.3/examples && /disk0/pokybuild/build1/tmp/sysroots/x86_64-linux/usr/bin/cmake -E cmake_link_script CMakeFiles/cdlookup.dir/link.txt --verbose=1^M -| /disk0/pokybuild/build1/tmp/sysroots/x86_64-linux/usr/bin/i586-poky-linux/i586-poky-linux-g++ -march=i586 --sysroot=/disk0/pokybuild/build1/tmp/sysroots/i586-poky-linux -fpermissive -Wl,-O1 -Wl,--as-needed CMakeFiles/cdlookup.dir/cdlookup.cpp.o -o cdlookup -rdynamic ../src/libmusicbrainz3.so.6.3.0 -lneon -Wl,-rpath,/disk0/pokybuild/build1/tmp/work/i586-poky-linux/libmusicbrainz-3.0.3-r0/libmusicbrainz-3.0.3/src^M -| /disk0/pokybuild/build1/tmp/sysroots/x86_64-linux/usr/libexec/i586-poky-linux/gcc/i586-poky-linux/4.5.1/ld: ~I: invalid DSO for symbol `pthread_cancel@@GLIBC_2.0' definition^M -| /disk0/pokybuild/build1/tmp/sysroots/i586-poky-linux/lib/libpthread.so.0: could not read symbols: Bad value^M -| collect2: ld returned 1 exit status^M -| make[2]: *** [examples/cdlookup] Error 1^M -| make[2]: Leaving directory `/disk0/pokybuild/build1/tmp/work/i586-poky-linux/libmusicbrainz-3.0.3-r0/libmusicbrainz-3.0.3' - -fixing the issue by making linking of libpthread explicit. - -Nitin A Kamble <nitin.a.kamble@intel.com> -Date: 2011/01/10 - -Index: libmusicbrainz-3.0.3/examples/CMakeLists.txt -=================================================================== ---- libmusicbrainz-3.0.3.orig/examples/CMakeLists.txt -+++ libmusicbrainz-3.0.3/examples/CMakeLists.txt -@@ -1,5 +1,5 @@ - INCLUDE_DIRECTORIES(${CMAKE_CURRENT_SOURCE_DIR}/../include) --LINK_LIBRARIES(musicbrainz3 ${NEON_LIBRARIES}) -+LINK_LIBRARIES(musicbrainz3 ${NEON_LIBRARIES} pthread) - ADD_EXECUTABLE(cdlookup cdlookup.cpp) - ADD_EXECUTABLE(findartist findartist.cpp) - ADD_EXECUTABLE(findtrack findtrack.cpp) |