diff options
| author | Øyvind Harboe <oyvind.harboe@zylin.com> | 2010-03-16 14:13:03 +0100 |
|---|---|---|
| committer | Øyvind Harboe <oyvind.harboe@zylin.com> | 2010-03-18 08:43:19 +0100 |
| commit | 36df240cea04990e8c18aa0b90bd63374f22dbd3 (patch) | |
| tree | 5e8573d7c54222bacf2389880e659b100e3754e2 /src/jtag/core.c | |
| parent | fccdfc1cd78ddfb687e0d1fc630c3fa10af2b5f9 (diff) | |
| download | openocd+libswd-36df240cea04990e8c18aa0b90bd63374f22dbd3.tar.gz openocd+libswd-36df240cea04990e8c18aa0b90bd63374f22dbd3.tar.bz2 openocd+libswd-36df240cea04990e8c18aa0b90bd63374f22dbd3.tar.xz openocd+libswd-36df240cea04990e8c18aa0b90bd63374f22dbd3.zip | |
jtag: cut down on usage of unintended modification of global end state
jtag_get/set_end_state() is now deprecated.
There were lots of places in the code where the end state was
unintentionally modified.
The big Q is whether there were any places where the intention
was to modify the end state. 0.5 is a long way off, so we'll
get a fair amount of testing.
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Diffstat (limited to 'src/jtag/core.c')
| -rw-r--r-- | src/jtag/core.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/jtag/core.c b/src/jtag/core.c index 9792280b..a09472a7 100644 --- a/src/jtag/core.c +++ b/src/jtag/core.c @@ -743,7 +743,8 @@ void jtag_add_reset(int req_tlr_or_trst, int req_srst) } } -tap_state_t jtag_set_end_state(tap_state_t state) +/* DEPRECATED! store such global state outside JTAG layer */ +void jtag_set_end_state(tap_state_t state) { if ((state == TAP_DRSHIFT)||(state == TAP_IRSHIFT)) { @@ -752,9 +753,9 @@ tap_state_t jtag_set_end_state(tap_state_t state) if (state != TAP_INVALID) cmd_queue_end_state = state; - return cmd_queue_end_state; } +/* DEPRECATED! store such global state outside JTAG layer */ tap_state_t jtag_get_end_state(void) { return cmd_queue_end_state; |