diff options
| author | David Brownell <dbrownell@users.sourceforge.net> | 2009-11-22 15:50:24 -0800 |
|---|---|---|
| committer | David Brownell <dbrownell@users.sourceforge.net> | 2009-11-22 15:50:24 -0800 |
| commit | fa9b0e2167c295c1f0de349563b893540fc73cb0 (patch) | |
| tree | d753627d500b4612c1b38ba02824d5933c3237b4 /src/target/arm11.h | |
| parent | af7f6891e98d538eabcf137d89f28bf3406a4999 (diff) | |
| download | openocd+libswd-fa9b0e2167c295c1f0de349563b893540fc73cb0.tar.gz openocd+libswd-fa9b0e2167c295c1f0de349563b893540fc73cb0.tar.bz2 openocd+libswd-fa9b0e2167c295c1f0de349563b893540fc73cb0.tar.xz openocd+libswd-fa9b0e2167c295c1f0de349563b893540fc73cb0.zip | |
ARM11: macro cleanup
Make this code look more like the rest of the OpenOCD code.
- Use calloc() directly, not NEW() ... and fix some potential
memory leaks while we're at it.
- Remove FNC_INFO ... it's a NOP that just clutters things,
and it's trivial for developers to add tracing as needed.
- Replace FNC_INFO_NOTIMPLEMENTED with LOG_WARNING calls;
ditto. And stop having those call sites wrongly succeed!
- Waste less space with the CHECK_RETVAL() macro.
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Diffstat (limited to 'src/target/arm11.h')
| -rw-r--r-- | src/target/arm11.h | 25 |
1 files changed, 9 insertions, 16 deletions
diff --git a/src/target/arm11.h b/src/target/arm11.h index 0b379294..3d7841d5 100644 --- a/src/target/arm11.h +++ b/src/target/arm11.h @@ -25,27 +25,20 @@ #include "armv4_5.h" -#define NEW(type, variable, items) \ - type * variable = calloc(1, sizeof(type) * items) - /* TEMPORARY -- till we switch to the shared infrastructure */ #define ARM11_REGCACHE_COUNT 20 #define ARM11_TAP_DEFAULT TAP_INVALID - -#define CHECK_RETVAL(action) \ -do { \ - int __retval = (action); \ - \ - if (__retval != ERROR_OK) \ - { \ - LOG_DEBUG("error while calling \"" # action "\""); \ - return __retval; \ - } \ - \ -} while (0) - +#define CHECK_RETVAL(action) \ + do { \ + int __retval = (action); \ + if (__retval != ERROR_OK) { \ + LOG_DEBUG("error while calling \"%s\"", \ + # action ); \ + return __retval; \ + } \ + } while (0) struct arm11_register_history { |