diff options
| author | David Brownell <dbrownell@users.sourceforge.net> | 2009-11-20 16:27:24 -0800 |
|---|---|---|
| committer | David Brownell <dbrownell@users.sourceforge.net> | 2009-11-20 16:27:24 -0800 |
| commit | 69c751956293e822faa6cf844f2864d81c36a578 (patch) | |
| tree | 5a13deb8230c7a3436e53e9618e27ab6421a08e4 /src/target/arm7tdmi.c | |
| parent | 85fe1506a2296493d13368e545fa2d4ddb13ea72 (diff) | |
| download | openocd+libswd-69c751956293e822faa6cf844f2864d81c36a578.tar.gz openocd+libswd-69c751956293e822faa6cf844f2864d81c36a578.tar.bz2 openocd+libswd-69c751956293e822faa6cf844f2864d81c36a578.tar.xz openocd+libswd-69c751956293e822faa6cf844f2864d81c36a578.zip | |
ARM: pass 'struct reg *' to register r/w routines
Implementations need to access the register struct they modify;
make it easier and less error-prone to identify the instance.
(This removes over 10% of the ARMV4_5_CORE_REG_MODE nastiness...)
Plus some minor fixes noted when making these updates: ARM7/ARM9
accessor methods should be static; don't leave CPSR wrongly marked
"dirty"; note significant XScale omissions in register handling;
and have armv4_5_build_reg_cache() record its result.
Rename "struct armv4_5_core_reg" as "struct arm_reg"; it's used
for more than those older architecture generations.
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Diffstat (limited to 'src/target/arm7tdmi.c')
| -rw-r--r-- | src/target/arm7tdmi.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/target/arm7tdmi.c b/src/target/arm7tdmi.c index 3bd52364..e7ea768f 100644 --- a/src/target/arm7tdmi.c +++ b/src/target/arm7tdmi.c @@ -644,7 +644,6 @@ static void arm7tdmi_build_reg_cache(struct target *target) struct armv4_5_common_s *armv4_5 = target_to_armv4_5(target); (*cache_p) = armv4_5_build_reg_cache(target, armv4_5); - armv4_5->core_cache = (*cache_p); } int arm7tdmi_init_target(struct command_context *cmd_ctx, struct target *target) |