diff options
| author | David Brownell <dbrownell@users.sourceforge.net> | 2009-11-17 09:06:45 -0800 |
|---|---|---|
| committer | David Brownell <dbrownell@users.sourceforge.net> | 2009-11-17 09:06:45 -0800 |
| commit | f4788652e45662d1e43933dc0620561bc4cddae0 (patch) | |
| tree | 0cda3c8b5ad766f3dea26d83c2a70b7cb52837d7 /src/target/cortex_m3.c | |
| parent | 959b373f8cdc2c1ad11c67c6916f88f48769438f (diff) | |
| download | openocd+libswd-f4788652e45662d1e43933dc0620561bc4cddae0.tar.gz openocd+libswd-f4788652e45662d1e43933dc0620561bc4cddae0.tar.bz2 openocd+libswd-f4788652e45662d1e43933dc0620561bc4cddae0.tar.xz openocd+libswd-f4788652e45662d1e43933dc0620561bc4cddae0.zip | |
target: simplify register get/set ops
No need to indirect from registered integers to pointers.
Just stash the pointers directly in the register struct,
and don't even bother registering.
This is a small code shrink, speeds register access just
a smidgeon, and gets rid of another rude exit() path.
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Diffstat (limited to 'src/target/cortex_m3.c')
| -rw-r--r-- | src/target/cortex_m3.c | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/src/target/cortex_m3.c b/src/target/cortex_m3.c index 7e48dae1..c7b978b7 100644 --- a/src/target/cortex_m3.c +++ b/src/target/cortex_m3.c @@ -1478,7 +1478,10 @@ static struct dwt_reg dwt_comp[] = { #undef DWT_COMPARATOR }; -static int dwt_reg_type = -1; +static const struct reg_arch_type dwt_reg_type = { + .get = cortex_m3_dwt_get_reg, + .set = cortex_m3_dwt_set_reg, +}; static void cortex_m3_dwt_addreg(struct target *t, struct reg *r, struct dwt_reg *d) @@ -1495,7 +1498,7 @@ cortex_m3_dwt_addreg(struct target *t, struct reg *r, struct dwt_reg *d) r->size = d->size; r->value = &state->value; r->arch_info = state; - r->arch_type = dwt_reg_type; + r->type = &dwt_reg_type; } static void @@ -1512,10 +1515,6 @@ cortex_m3_dwt_setup(struct cortex_m3_common *cm3, struct target *target) return; } - if (dwt_reg_type < 0) - dwt_reg_type = register_reg_arch_type(cortex_m3_dwt_get_reg, - cortex_m3_dwt_set_reg); - cm3->dwt_num_comp = (dwtcr >> 28) & 0xF; cm3->dwt_comp_available = cm3->dwt_num_comp; cm3->dwt_comparator_list = calloc(cm3->dwt_num_comp, |