diff options
| author | David Brownell <dbrownell@users.sourceforge.net> | 2009-10-25 13:06:47 -0700 |
|---|---|---|
| committer | David Brownell <dbrownell@users.sourceforge.net> | 2009-10-25 13:06:47 -0700 |
| commit | 2a8aa3b7efb590cabd7ee930dbb68fd64e028099 (patch) | |
| tree | e345f77f89b8e9086f2053acf4a458ba3324df32 /src/target/xscale.h | |
| parent | 0b436497e047a13ff3dbae46af0eb67376ea5acf (diff) | |
| download | openocd+libswd-2a8aa3b7efb590cabd7ee930dbb68fd64e028099.tar.gz openocd+libswd-2a8aa3b7efb590cabd7ee930dbb68fd64e028099.tar.bz2 openocd+libswd-2a8aa3b7efb590cabd7ee930dbb68fd64e028099.tar.xz openocd+libswd-2a8aa3b7efb590cabd7ee930dbb68fd64e028099.zip | |
xscale: always reload handler after reset
Remove needless debug handler state.
- "handler_installed" became wrong as soon as the second TRST+SRST
reset was issued ... so the handler was never reloaded after the
reset removed it from the mini-icache.
This fixes the bug where subsequent resets fail on PXA255 (if the
first one even worked, which is uncommon). Other XScale chips
would have problems too; PXA270 seems to have, IXP425 maybe not.
- "handler_running" was never tested; it's pointless.
Plus a related bugfix: invalidate OpenOCD's ARM register cache on reset.
It was no more valid than the XScale's mini-icache. (Though ... such
invalidations might be better done in "SRST asserted" callbacks.)
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Diffstat (limited to 'src/target/xscale.h')
| -rw-r--r-- | src/target/xscale.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/target/xscale.h b/src/target/xscale.h index a5d83ee6..4b34cf88 100644 --- a/src/target/xscale.h +++ b/src/target/xscale.h @@ -86,8 +86,6 @@ typedef struct xscale_common_s reg_cache_t *reg_cache; /* current state of the debug handler */ - int handler_installed; - int handler_running; uint32_t handler_address; /* target-endian buffers with exception vectors */ |