Uwe Hermann <uwe@hermann-uwe.de> eal _CPUTAPID entry for the LPC2148. I don't know

if they're the same for all LPC214x, this number is from an Olimex
LPC-H2148. The chip on that board is LPC2148FBD64.

Also fix a few cosmetic issues and comments in the file and add
more docs and pointers to the datasheet.


git-svn-id: svn://svn.berlios.de/openocd/trunk@1427 b42882b7-edfa-0310-969c-e2dbd0fdcd60

1 files changed, 24 insertions, 22 deletions

diff --git a/src/target/target/lpc2148.cfg b/src/target/target/lpc2148.cfg
index 7b701ab6..a728195c 100644
--- a/src/target/target/lpc2148.cfg
+++ b/src/target/target/lpc2148.cfg
@@ -1,49 +1,51 @@
-
 if { [info exists CHIPNAME] } {	
-   set  _CHIPNAME $CHIPNAME    
-} else {	 
-   set  _CHIPNAME lpc2148
+   set _CHIPNAME $CHIPNAME
+} else {
+   set _CHIPNAME lpc2148
 }
 
-if { [info exists ENDIAN] } {	
-   set  _ENDIAN $ENDIAN    
-} else {	 
-   set  _ENDIAN little
+if { [info exists ENDIAN] } {
+   set _ENDIAN $ENDIAN
+} else {
+   set _ENDIAN little
 }
 
 if { [info exists CPUTAPID ] } {
    set _CPUTAPID $CPUTAPID
 } else {
-  # force an error till we get a good number
-   set _CPUTAPID 0xffffffff
+   set _CPUTAPID 0x4f1f0f0f
 }
 
-#delays on reset lines
 jtag_nsrst_delay 200
 jtag_ntrst_delay 200
 
-# NOTE!!! LPCs need reset pulled while RTCK is low. 0 to activate 
+# NOTE!!! LPCs need reset pulled while RTCK is low. 0 to activate
 # JTAG, power-on reset is not enough, i.e. you need to perform a
-# reset before being able to talk to the LPC2148, attach is not
-# possible.
+# reset before being able to talk to the LPC2148, attach is not possible.
 
-#use combined on interfaces or targets that can't set TRST/SRST separately
 reset_config trst_and_srst srst_pulls_trst
 
-#jtag scan chain
 jtag newtap $_CHIPNAME cpu -irlen 4 -ircapture 0x1 -irmask 0xf -expected-id $_CPUTAPID
 
 set _TARGETNAME [format "%s.cpu" $_CHIPNAME]
+
 target create $_TARGETNAME arm7tdmi -endian $_ENDIAN -chain-position $_TARGETNAME -variant arm7tdmi-s_r4
+
 $_TARGETNAME configure -work-area-virt 0 -work-area-phys 0x40000000 -work-area-size 0x4000 -work-area-backup 0
+
 $_TARGETNAME configure -event reset-init {
-	# Force target into ARM state
+	# Force target into ARM state.
 	soft_reset_halt
-	#do not remap 0x0000-0x0020 to anything but the flash
-	mwb 0xE01FC040 0x01 
-	
-}
 
+	# Do not remap 0x0000-0x0020 to anything but the flash (i.e. select
+	# "User Flash Mode" where interrupt vectors are _not_ remapped,
+	# and reside in flash instead).
+	#
+	# See section 7.1 on page 32 ("Memory Mapping control register") in
+	# "UM10139: Volume 1: LPC214x User Manual", Rev. 02 -- 25 July 2006.
+	# http://www.standardics.nxp.com/support/documents/microcontrollers/pdf/user.manual.lpc2141.lpc2142.lpc2144.lpc2146.lpc2148.pdf
+	mwb 0xE01FC040 0x01
+}
 
-#flash bank lpc2000 <base> <size> 0 0 <target#> <variant>
+# flash bank lpc2000 <base> <size> 0 0 <target#> <variant> <clock> [calc_checksum]
 flash bank lpc2000 0x0 0x7d000 0 0 0 lpc2000_v2 14765