diff options
author | Zachary T Welch <zw@superlucidity.net> | 2009-11-29 15:58:16 -0800 |
---|---|---|
committer | Zachary T Welch <zw@superlucidity.net> | 2009-11-30 16:29:34 -0800 |
commit | bc9ae740730efacc2daa3ecbdb0ee75601ec18df (patch) | |
tree | 732893349ef7029662ecc98fd42d77e698d3d5b5 /BUGS | |
parent | c0630d8a58c525e09aa938c7a50d4c99d39a93a3 (diff) | |
download | openocd_libswd-bc9ae740730efacc2daa3ecbdb0ee75601ec18df.tar.gz openocd_libswd-bc9ae740730efacc2daa3ecbdb0ee75601ec18df.tar.bz2 openocd_libswd-bc9ae740730efacc2daa3ecbdb0ee75601ec18df.tar.xz openocd_libswd-bc9ae740730efacc2daa3ecbdb0ee75601ec18df.zip |
improve command_done() API and docs
command_done() does not need to return an error, but it needed
Doxygen comment. Provide some for copy_command_context as well.
Note: this audit revealed some potential bugs with the command context
implementation. There was a reason that commands were added at the
end of the list. Shallow copying of command_context means that
the list is shared between them. And commands added at the top-level
before the pre-existing commands will not be available in the shared
context as they were before. Yikes!
Fortunately, this does not seem to occur in general use, as
'add_help_text' gets registered in startup.tcl and claims the first slot
in my own test cases. Thus, it seems that we have been masking the issue
for now, but it shows the need for further architectural improvement in
the core command module.
Diffstat (limited to 'BUGS')
0 files changed, 0 insertions, 0 deletions