diff options
author | David Brownell <dbrownell@users.sourceforge.net> | 2010-03-21 22:49:23 -0700 |
---|---|---|
committer | David Brownell <dbrownell@users.sourceforge.net> | 2010-03-21 22:49:23 -0700 |
commit | c2f714bd4482cfe3c09efdc57e8b6b7e8536e181 (patch) | |
tree | 83900fb0f1ff94204aa4620a3c2aecfb4231b0c5 /src/hello.h | |
parent | b7811b76795aaeacfea0473bdca2c44826f20501 (diff) | |
download | openocd_libswd-c2f714bd4482cfe3c09efdc57e8b6b7e8536e181.tar.gz openocd_libswd-c2f714bd4482cfe3c09efdc57e8b6b7e8536e181.tar.bz2 openocd_libswd-c2f714bd4482cfe3c09efdc57e8b6b7e8536e181.tar.xz openocd_libswd-c2f714bd4482cfe3c09efdc57e8b6b7e8536e181.zip |
ft2232 init mess cleanup
In the ft2232 driver, initialization for many layouts punts to a routine
called usbjtag_init(), instead of a routine specific to each layout.
That routine is a mess built around a "what type layout am I" core.
That's a bad design ... in this case, especially so, since it bypasses
the layout-specific dispatch which was just done, and obfuscates the
initialization which is at least somewhat generic, instead of being
specific to the "usbjtag" layout.
Split and document out the generic parts of usbjtag_init(), and make
the rest of those layouts have layout-specific init methods. Also,
rename usbjtag_reset() ... that also was not specific to the "usbjtag"
layout, and thus contributed to the previous code structure confusion.
(Eventually, all layout-specific code (and method tables) should probably
live in files specific to each layout. These changes will facilitate
those and other cleanups to this driver.)
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Diffstat (limited to 'src/hello.h')
0 files changed, 0 insertions, 0 deletions