summaryrefslogtreecommitdiff
path: root/src/helper
diff options
context:
space:
mode:
authorZachary T Welch <zw@superlucidity.net>2009-11-20 16:36:32 -0800
committerZachary T Welch <zw@superlucidity.net>2009-11-25 10:29:06 -0800
commitbe482a5335dd35ee1fa163faa0af481b2ec65b70 (patch)
treeda29dc2f15edfcc5e3cb2cbf3e8423967486e580 /src/helper
parented90b6659f6d6b98b59d65f7a889e0221bdffa87 (diff)
downloadopenocd_libswd-be482a5335dd35ee1fa163faa0af481b2ec65b70.tar.gz
openocd_libswd-be482a5335dd35ee1fa163faa0af481b2ec65b70.tar.bz2
openocd_libswd-be482a5335dd35ee1fa163faa0af481b2ec65b70.tar.xz
openocd_libswd-be482a5335dd35ee1fa163faa0af481b2ec65b70.zip
log: improve initialization
Removes redundant assignment of start_ms from log_register_commands(). Eliminates command_context parameter and return value. Adds Doxygen comment block for this API call.
Diffstat (limited to 'src/helper')
-rw-r--r--src/helper/log.c11
-rw-r--r--src/helper/log.h5
2 files changed, 7 insertions, 9 deletions
diff --git a/src/helper/log.c b/src/helper/log.c
index 3799fb32..27fa8317 100644
--- a/src/helper/log.c
+++ b/src/helper/log.c
@@ -336,25 +336,20 @@ static struct command_registration log_command_handlers[] = {
int log_register_commands(struct command_context *cmd_ctx)
{
- start = timeval_ms();
-
return register_commands(cmd_ctx, NULL, log_command_handlers);
}
-int log_init(struct command_context *cmd_ctx)
+void log_init(void)
{
- /* set defaults for daemon configuration, if not set by cmdline or cfgfile */
+ /* set defaults for daemon configuration,
+ * if not set by cmdline or cfgfile */
if (debug_level == -1)
debug_level = LOG_LVL_INFO;
if (log_output == NULL)
- {
log_output = stderr;
- }
start = last_time = timeval_ms();
-
- return ERROR_OK;
}
int set_log_output(struct command_context *cmd_ctx, FILE *output)
diff --git a/src/helper/log.h b/src/helper/log.h
index 6f7c24a8..f2d19d16 100644
--- a/src/helper/log.h
+++ b/src/helper/log.h
@@ -66,7 +66,10 @@ void log_printf_lf(enum log_levels level, const char *file, unsigned line,
const char *function, const char *format, ...)
__attribute__ ((format (PRINTF_ATTRIBUTE_FORMAT, 5, 6)));
-int log_init(struct command_context *cmd_ctx);
+/**
+ * Initialize logging module. Call during program startup.
+ */
+void log_init(void);
int set_log_output(struct command_context *cmd_ctx, FILE *output);
int log_register_commands(struct command_context *cmd_ctx);