summaryrefslogtreecommitdiff
path: root/src/helper
diff options
context:
space:
mode:
authorZachary T Welch <zw@superlucidity.net>2009-11-10 00:02:18 -0800
committerZachary T Welch <zw@superlucidity.net>2009-11-13 10:55:27 -0800
commitd22270e0ed291d3b08fd03a25181b279ca5e0911 (patch)
treee9467fb7e4a05043d18eb747d0b4bfd89511abf1 /src/helper
parenta585bdf7269ce5c861c83ee3294ba1f074e9c877 (diff)
downloadopenocd_libswd-d22270e0ed291d3b08fd03a25181b279ca5e0911.tar.gz
openocd_libswd-d22270e0ed291d3b08fd03a25181b279ca5e0911.tar.bz2
openocd_libswd-d22270e0ed291d3b08fd03a25181b279ca5e0911.tar.xz
openocd_libswd-d22270e0ed291d3b08fd03a25181b279ca5e0911.zip
command_handler_t: make argc unsigned
The number of command arguments will always be 0 or more, so use the right type in handlers. This has a cascading effect up through the layers, but the new COMMAND_HANDLER macros prevented total chaos.
Diffstat (limited to 'src/helper')
-rw-r--r--src/helper/command.h2
-rw-r--r--src/helper/ioutil.c2
2 files changed, 2 insertions, 2 deletions
diff --git a/src/helper/command.h b/src/helper/command.h
index 74c6f367..55773156 100644
--- a/src/helper/command.h
+++ b/src/helper/command.h
@@ -88,7 +88,7 @@ typedef struct command_context_s
*/
#define __COMMAND_HANDLER(name, extra...) \
int name(struct command_context_s *cmd_ctx, \
- char *cmd, char **args, int argc, ##extra)
+ char *cmd, char **args, unsigned argc, ##extra)
/**
* Use this to macro to call a command helper (or a nested handler).
diff --git a/src/helper/ioutil.c b/src/helper/ioutil.c
index 1423462c..3a629611 100644
--- a/src/helper/ioutil.c
+++ b/src/helper/ioutil.c
@@ -214,9 +214,9 @@ COMMAND_HANDLER(handle_append_command)
config_file = fopen(args[0], "a");
if (config_file != NULL)
{
- int i;
fseek(config_file, 0, SEEK_END);
+ unsigned i;
for (i = 1; i < argc; i++)
{
if (fwrite(args[i], 1, strlen(args[i]), config_file) != strlen(args[i]))