summaryrefslogtreecommitdiff
path: root/src/target
diff options
context:
space:
mode:
authorØyvind Harboe <oyvind.harboe@zylin.com>2010-06-14 09:30:37 +0200
committerØyvind Harboe <oyvind.harboe@zylin.com>2010-06-14 09:30:37 +0200
commitaa2de47d3ce4d484c124f0449702f511aab49112 (patch)
treeb4633b84bf2da225ae60db343656b8702ca07256 /src/target
parentbac52fbac83f0d04fb51a2547e6ae76fff1ac1dc (diff)
downloadopenocd_libswd-aa2de47d3ce4d484c124f0449702f511aab49112.tar.gz
openocd_libswd-aa2de47d3ce4d484c124f0449702f511aab49112.tar.bz2
openocd_libswd-aa2de47d3ce4d484c124f0449702f511aab49112.tar.xz
openocd_libswd-aa2de47d3ce4d484c124f0449702f511aab49112.zip
target: fix retval gaffe in mwX commands
failure to write to memory was not propagated. This is an interesting case of broken error handling: with exceptions we wouldn't have had this at all, and I also wonder if there is a GCC option to warn about these kinds of potential bugs. Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Diffstat (limited to 'src/target')
-rw-r--r--src/target/target.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/target/target.c b/src/target/target.c
index 01d94416..435d7b66 100644
--- a/src/target/target.c
+++ b/src/target/target.c
@@ -2378,7 +2378,7 @@ static int target_fill_mem(struct target *target,
{
current = chunk_size;
}
- int retval = fn(target, address + x * data_size, data_size, current, target_buf);
+ retval = fn(target, address + x * data_size, data_size, current, target_buf);
if (retval != ERROR_OK)
{
break;