diff options
author | oharboe <oharboe@b42882b7-edfa-0310-969c-e2dbd0fdcd60> | 2008-03-02 08:39:02 +0000 |
---|---|---|
committer | oharboe <oharboe@b42882b7-edfa-0310-969c-e2dbd0fdcd60> | 2008-03-02 08:39:02 +0000 |
commit | 2c5fc392f019e78ae858ffd761bcb859f898ff53 (patch) | |
tree | 0432ee4ce828b0b2a84873c092d2ca42a2e0e15b /src/flash | |
parent | 2e21083c19eb6f0336fb4986215ca390f422a8cc (diff) | |
download | openocd+libswd-2c5fc392f019e78ae858ffd761bcb859f898ff53.tar.gz openocd+libswd-2c5fc392f019e78ae858ffd761bcb859f898ff53.tar.bz2 openocd+libswd-2c5fc392f019e78ae858ffd761bcb859f898ff53.tar.xz openocd+libswd-2c5fc392f019e78ae858ffd761bcb859f898ff53.zip |
Uwe Hermann tightned up comments, etc. to follow OpenOCD policy
git-svn-id: svn://svn.berlios.de/openocd/trunk@431 b42882b7-edfa-0310-969c-e2dbd0fdcd60
Diffstat (limited to 'src/flash')
-rw-r--r-- | src/flash/cfi.c | 3 | ||||
-rw-r--r-- | src/flash/ecos.c | 39 | ||||
-rw-r--r-- | src/flash/str9xpec.c | 8 |
3 files changed, 26 insertions, 24 deletions
diff --git a/src/flash/cfi.c b/src/flash/cfi.c index 8567a444..f4968a8b 100644 --- a/src/flash/cfi.c +++ b/src/flash/cfi.c @@ -129,7 +129,8 @@ void cfi_fixup(flash_bank_t *bank, cfi_fixup_t *fixups) } } -inline u32 flash_address(flash_bank_t *bank, int sector, u32 offset) +/* inline u32 flash_address(flash_bank_t *bank, int sector, u32 offset) */ +__inline__ u32 flash_address(flash_bank_t *bank, int sector, u32 offset) { /* while the sector list isn't built, only accesses to sector 0 work */ if (sector == 0) diff --git a/src/flash/ecos.c b/src/flash/ecos.c index 57c760fd..6a312ced 100644 --- a/src/flash/ecos.c +++ b/src/flash/ecos.c @@ -82,21 +82,21 @@ char * flash_errmsg(int err); #ifndef __ECOS -#define FLASH_ERR_OK 0x00 // No error - operation complete -#define FLASH_ERR_INVALID 0x01 // Invalid FLASH address -#define FLASH_ERR_ERASE 0x02 // Error trying to erase -#define FLASH_ERR_LOCK 0x03 // Error trying to lock/unlock -#define FLASH_ERR_PROGRAM 0x04 // Error trying to program -#define FLASH_ERR_PROTOCOL 0x05 // Generic error -#define FLASH_ERR_PROTECT 0x06 // Device/region is write-protected -#define FLASH_ERR_NOT_INIT 0x07 // FLASH info not yet initialized -#define FLASH_ERR_HWR 0x08 // Hardware (configuration?) problem -#define FLASH_ERR_ERASE_SUSPEND 0x09 // Device is in erase suspend mode -#define FLASH_ERR_PROGRAM_SUSPEND 0x0a // Device is in in program suspend mode -#define FLASH_ERR_DRV_VERIFY 0x0b // Driver failed to verify data -#define FLASH_ERR_DRV_TIMEOUT 0x0c // Driver timed out waiting for device -#define FLASH_ERR_DRV_WRONG_PART 0x0d // Driver does not support device -#define FLASH_ERR_LOW_VOLTAGE 0x0e // Not enough juice to complete job +#define FLASH_ERR_OK 0x00 /* No error - operation complete */ +#define FLASH_ERR_INVALID 0x01 /* Invalid FLASH address */ +#define FLASH_ERR_ERASE 0x02 /* Error trying to erase */ +#define FLASH_ERR_LOCK 0x03 /* Error trying to lock/unlock */ +#define FLASH_ERR_PROGRAM 0x04 /* Error trying to program */ +#define FLASH_ERR_PROTOCOL 0x05 /* Generic error */ +#define FLASH_ERR_PROTECT 0x06 /* Device/region is write-protected */ +#define FLASH_ERR_NOT_INIT 0x07 /* FLASH info not yet initialized */ +#define FLASH_ERR_HWR 0x08 /* Hardware (configuration?) problem */ +#define FLASH_ERR_ERASE_SUSPEND 0x09 /* Device is in erase suspend mode */ +#define FLASH_ERR_PROGRAM_SUSPEND 0x0a /* Device is in in program suspend mode */ +#define FLASH_ERR_DRV_VERIFY 0x0b /* Driver failed to verify data */ +#define FLASH_ERR_DRV_TIMEOUT 0x0c /* Driver timed out waiting for device */ +#define FLASH_ERR_DRV_WRONG_PART 0x0d /* Driver does not support device */ +#define FLASH_ERR_LOW_VOLTAGE 0x0e /* Not enough juice to complete job */ char * @@ -158,9 +158,10 @@ int ecosflash_flash_bank_command(struct command_context_s *cmd_ctx, char *cmd, c bank->driver_priv = info; info->driverPath=strdup(args[6]); - // eCos flash sector sizes are not exposed to OpenOCD, use 0x10000 as - // a way to improve impeadance matach between OpenOCD and eCos flash - // driver + /* eCos flash sector sizes are not exposed to OpenOCD, use 0x10000 as + * a way to improve impeadance matach between OpenOCD and eCos flash + * driver. + */ int i = 0; u32 offset = 0; bank->num_sectors=bank->size/sectorSize; @@ -238,7 +239,7 @@ static int const OFFSET_GET_WORKAREA_SIZE=0x4; int runCode(ecosflash_flash_bank_t *info, u32 codeStart, u32 codeStop, u32 r0, u32 r1, u32 r2, u32 *result, - // timeout in ms + /* timeout in ms */ int timeout) { target_t *target=info->target; diff --git a/src/flash/str9xpec.c b/src/flash/str9xpec.c index ea7aa97f..4a24d85d 100644 --- a/src/flash/str9xpec.c +++ b/src/flash/str9xpec.c @@ -794,8 +794,8 @@ int str9xpec_write(struct flash_bank_s *bank, u8 *buffer, u32 offset, u32 count) if ((status & ISC_STATUS_ERROR) != STR9XPEC_ISC_SUCCESS) return ERROR_FLASH_OPERATION_FAILED; - //if ((status & ISC_STATUS_INT_ERROR) != STR9XPEC_ISC_INTFAIL) - // return ERROR_FLASH_OPERATION_FAILED; + /* if ((status & ISC_STATUS_INT_ERROR) != STR9XPEC_ISC_INTFAIL) + return ERROR_FLASH_OPERATION_FAILED; */ dwords_remaining--; bytes_written += 8; @@ -854,8 +854,8 @@ int str9xpec_write(struct flash_bank_s *bank, u8 *buffer, u32 offset, u32 count) if ((status & ISC_STATUS_ERROR) != STR9XPEC_ISC_SUCCESS) return ERROR_FLASH_OPERATION_FAILED; - //if ((status & ISC_STATUS_INT_ERROR) != STR9XPEC_ISC_INTFAIL) - // return ERROR_FLASH_OPERATION_FAILED; + /* if ((status & ISC_STATUS_INT_ERROR) != STR9XPEC_ISC_INTFAIL) + return ERROR_FLASH_OPERATION_FAILED; */ } free(scanbuf); |