diff options
| author | David Brownell <dbrownell@users.sourceforge.net> | 2009-11-17 09:06:45 -0800 |
|---|---|---|
| committer | David Brownell <dbrownell@users.sourceforge.net> | 2009-11-17 09:06:45 -0800 |
| commit | f4788652e45662d1e43933dc0620561bc4cddae0 (patch) | |
| tree | 0cda3c8b5ad766f3dea26d83c2a70b7cb52837d7 /src/target/mips32.c | |
| parent | 959b373f8cdc2c1ad11c67c6916f88f48769438f (diff) | |
| download | openocd+libswd-f4788652e45662d1e43933dc0620561bc4cddae0.tar.gz openocd+libswd-f4788652e45662d1e43933dc0620561bc4cddae0.tar.bz2 openocd+libswd-f4788652e45662d1e43933dc0620561bc4cddae0.tar.xz openocd+libswd-f4788652e45662d1e43933dc0620561bc4cddae0.zip | |
target: simplify register get/set ops
No need to indirect from registered integers to pointers.
Just stash the pointers directly in the register struct,
and don't even bother registering.
This is a small code shrink, speeds register access just
a smidgeon, and gets rid of another rude exit() path.
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Diffstat (limited to 'src/target/mips32.c')
| -rw-r--r-- | src/target/mips32.c | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/src/target/mips32.c b/src/target/mips32.c index 1315744c..f986079d 100644 --- a/src/target/mips32.c +++ b/src/target/mips32.c @@ -97,11 +97,8 @@ struct reg mips32_gdb_dummy_fp_reg = .valid = 1, .size = 32, .arch_info = NULL, - .arch_type = 0, }; -int mips32_core_reg_arch_type = -1; - int mips32_get_core_reg(struct reg *reg) { int retval; @@ -278,6 +275,11 @@ int mips32_arch_state(struct target *target) return ERROR_OK; } +static const struct reg_arch_type mips32_reg_type = { + .get = mips32_get_core_reg, + .set = mips32_set_core_reg, +}; + struct reg_cache *mips32_build_reg_cache(struct target *target) { /* get pointers to arch-specific information */ @@ -290,9 +292,6 @@ struct reg_cache *mips32_build_reg_cache(struct target *target) struct mips32_core_reg *arch_info = malloc(sizeof(struct mips32_core_reg) * num_regs); int i; - if (mips32_core_reg_arch_type == -1) - mips32_core_reg_arch_type = register_reg_arch_type(mips32_get_core_reg, mips32_set_core_reg); - register_init_dummy(&mips32_gdb_dummy_fp_reg); /* Build the process context cache */ @@ -313,7 +312,7 @@ struct reg_cache *mips32_build_reg_cache(struct target *target) reg_list[i].value = calloc(1, 4); reg_list[i].dirty = 0; reg_list[i].valid = 0; - reg_list[i].arch_type = mips32_core_reg_arch_type; + reg_list[i].type = &mips32_reg_type; reg_list[i].arch_info = &arch_info[i]; } |