summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authoroharboe <oharboe@b42882b7-edfa-0310-969c-e2dbd0fdcd60>2009-05-08 06:14:08 +0000
committeroharboe <oharboe@b42882b7-edfa-0310-969c-e2dbd0fdcd60>2009-05-08 06:14:08 +0000
commit75f98d16494849f9e102a67e7820075b60aeb9b1 (patch)
tree93acd3281cf5b1ae89ab2e0a8541fe81328f9f17 /src
parentf2676adb3cf90ebd64a44798cfdfac4a352608a4 (diff)
downloadopenocd+libswd-75f98d16494849f9e102a67e7820075b60aeb9b1.tar.gz
openocd+libswd-75f98d16494849f9e102a67e7820075b60aeb9b1.tar.bz2
openocd+libswd-75f98d16494849f9e102a67e7820075b60aeb9b1.tar.xz
openocd+libswd-75f98d16494849f9e102a67e7820075b60aeb9b1.zip
added comments w.r.t. potential performance problems
git-svn-id: svn://svn.berlios.de/openocd/trunk@1663 b42882b7-edfa-0310-969c-e2dbd0fdcd60
Diffstat (limited to 'src')
-rw-r--r--src/target/arm7tdmi.c7
-rw-r--r--src/target/arm_adi_v5.c6
2 files changed, 13 insertions, 0 deletions
diff --git a/src/target/arm7tdmi.c b/src/target/arm7tdmi.c
index 5f45ad99..647e68b9 100644
--- a/src/target/arm7tdmi.c
+++ b/src/target/arm7tdmi.c
@@ -372,6 +372,13 @@ void arm7tdmi_change_to_arm(target_t *target, u32 *r0, u32 *pc)
*pc -= 0xa;
}
+
+/* FIX!!! is this a potential performance bottleneck w.r.t. requiring too many
+ * roundtrips when jtag_execute_queue() has a large overhead(e.g. for USB)s?
+ *
+ * The solution is to arrange for a large out/in scan in this loop and
+ * and convert data afterwards.
+ */
void arm7tdmi_read_core_regs(target_t *target, u32 mask, u32* core_regs[16])
{
int i;
diff --git a/src/target/arm_adi_v5.c b/src/target/arm_adi_v5.c
index c1555d9f..871caefc 100644
--- a/src/target/arm_adi_v5.c
+++ b/src/target/arm_adi_v5.c
@@ -867,6 +867,12 @@ int mem_ap_read_buf_u16(swjdp_common_t *swjdp, u8 *buffer, int count, u32 addres
return retval;
}
+/* FIX!!! is this a potential performance bottleneck w.r.t. requiring too many
+ * roundtrips when jtag_execute_queue() has a large overhead(e.g. for USB)s?
+ *
+ * The solution is to arrange for a large out/in scan in this loop and
+ * and convert data afterwards.
+ */
int mem_ap_read_buf_packed_u8(swjdp_common_t *swjdp, u8 *buffer, int count, u32 address)
{
u32 invalue;